From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/3] dm: usb: Move descriptor setup code into its own function
Date: Tue, 14 Apr 2015 05:56:01 +0200 [thread overview]
Message-ID: <201504140556.01437.marex@denx.de> (raw)
In-Reply-To: <1428981544-22643-1-git-send-email-sjg@chromium.org>
On Tuesday, April 14, 2015 at 05:19:02 AM, Simon Glass wrote:
> usb_new_device() is far too long and does far too much. As a first step,
> move the code that does initial setup and reads a descriptor into its own
> function called usb_setup_descriptor().
>
> For XHCI the init order is different - we set up the device but don't
> actually read the descriptor until after we set an address. Support this
> option as a parameter to usb_setup_descriptor().
>
> Avoid changing this torturous code more than necessary to make it easy to
> review.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-04-14 3:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 3:19 [U-Boot] [PATCH v3 1/3] dm: usb: Move descriptor setup code into its own function Simon Glass
2015-04-14 3:19 ` [U-Boot] [PATCH v3 2/3] dm: usb: Split out more code from usb_new_device() Simon Glass
2015-04-14 3:56 ` Marek Vasut
2015-04-14 3:19 ` [U-Boot] [PATCH v3 3/3] dm: usb: Complete the splitting up of usb_new_device() Simon Glass
2015-04-14 3:56 ` Marek Vasut
2015-04-14 3:56 ` Marek Vasut [this message]
2015-04-14 14:56 ` [U-Boot] [PATCH v3 1/3] dm: usb: Move descriptor setup code into its own function Stephen Warren
2015-04-14 18:05 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504140556.01437.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.