From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wanpeng Li Subject: Re: [PATCH v2 4/4] KVM: x86: Clear CR2 on VCPU reset Date: Tue, 14 Apr 2015 18:03:26 +0800 Message-ID: <20150414100326.GA4101@kernel> References: <1427933438-12782-1-git-send-email-namit@cs.technion.ac.il> <1427933438-12782-5-git-send-email-namit@cs.technion.ac.il> Reply-To: Wanpeng Li Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: pbonzini@redhat.com, kvm@vger.kernel.org To: Nadav Amit Return-path: Received: from mga01.intel.com ([192.55.52.88]:64606 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753666AbbDNKVh (ORCPT ); Tue, 14 Apr 2015 06:21:37 -0400 Content-Disposition: inline In-Reply-To: <1427933438-12782-5-git-send-email-namit@cs.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: Hi Nadav, On Thu, Apr 02, 2015 at 03:10:38AM +0300, Nadav Amit wrote: >CR2 is not cleared as it should after reset. See Intel SDM table named "IA-32 >Processor States Following Power-up, Reset, or INIT". How you trigger the reset instead of the "Power-up" one? Regards, Wanpeng Li > >Signed-off-by: Nadav Amit >--- > arch/x86/kvm/x86.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >index e4ac17e..8fdad04 100644 >--- a/arch/x86/kvm/x86.c >+++ b/arch/x86/kvm/x86.c >@@ -7117,6 +7117,8 @@ void kvm_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event) > vcpu->arch.dr7 = DR7_FIXED_1; > kvm_update_dr7(vcpu); > >+ vcpu->arch.cr2 = 0; >+ > kvm_make_request(KVM_REQ_EVENT, vcpu); > vcpu->arch.apf.msr_val = 0; > vcpu->arch.st.msr_val = 0; >-- >1.9.1 > >-- >To unsubscribe from this list: send the line "unsubscribe kvm" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html