From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink Date: Tue, 14 Apr 2015 17:37:57 +0200 Message-ID: <20150414153757.GA10861@lunn.ch> References: <1429024817-21561-1-git-send-email-honli@redhat.com> <1429024817-21561-4-git-send-email-honli@redhat.com> <20150414152626.GJ7874@acer.localdomain> <552D33B0.6040808@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <552D33B0.6040808-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicolas Dichtel Cc: Patrick McHardy , Honggang Li , roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, maheshb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, jbenc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, elfring-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org, sfeldma-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alexander.h.duyck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Apr 14, 2015 at 05:35:12PM +0200, Nicolas Dichtel wrote: > Le 14/04/2015 17:26, Patrick McHardy a =E9crit : > >On 14.04, Honggang Li wrote: > [snip] > >>- return vlan->lowerdev->ifindex; > >>+ if (vlan && vlan->lowerdev) > >>+ return vlan->lowerdev->ifindex; > > > >That is completely useless. vlan (=3Dnetdev_priv) can not be NULL as > >netdev_priv() never returns NULL and vlan->lowerdev is always valid > >because a macvlan wouldn't make much sense otherwise. > > > And I suspect that it is the same for ipvlan and dsa. I agree about DSA. I don't see any way this could happen. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755921AbbDNPmr (ORCPT ); Tue, 14 Apr 2015 11:42:47 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:44553 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753196AbbDNPmj (ORCPT ); Tue, 14 Apr 2015 11:42:39 -0400 Date: Tue, 14 Apr 2015 17:37:57 +0200 From: Andrew Lunn To: Nicolas Dichtel Cc: Patrick McHardy , Honggang Li , roland@kernel.org, sean.hefty@intel.com, hal.rosenstock@gmail.com, davem@davemloft.net, alex.estrin@intel.com, dledford@redhat.com, edumazet@google.com, erezsh@mellanox.com, maheshb@google.com, jbenc@redhat.com, ebiederm@xmission.com, elfring@users.sourceforge.net, f.fainelli@gmail.com, linux@roeck-us.net, sfeldma@gmail.com, alexander.h.duyck@intel.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink Message-ID: <20150414153757.GA10861@lunn.ch> References: <1429024817-21561-1-git-send-email-honli@redhat.com> <1429024817-21561-4-git-send-email-honli@redhat.com> <20150414152626.GJ7874@acer.localdomain> <552D33B0.6040808@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <552D33B0.6040808@6wind.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2015 at 05:35:12PM +0200, Nicolas Dichtel wrote: > Le 14/04/2015 17:26, Patrick McHardy a écrit : > >On 14.04, Honggang Li wrote: > [snip] > >>- return vlan->lowerdev->ifindex; > >>+ if (vlan && vlan->lowerdev) > >>+ return vlan->lowerdev->ifindex; > > > >That is completely useless. vlan (=netdev_priv) can not be NULL as > >netdev_priv() never returns NULL and vlan->lowerdev is always valid > >because a macvlan wouldn't make much sense otherwise. > > > And I suspect that it is the same for ipvlan and dsa. I agree about DSA. I don't see any way this could happen. Andrew