From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 1/2] intel: Defer setting madv on the bo cache Date: Tue, 14 Apr 2015 12:38:56 -0700 Message-ID: <20150414193855.GA21514@intel.com> References: <1429024125-7859-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 8428C6E038 for ; Tue, 14 Apr 2015 12:38:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1429024125-7859-1-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBcHIgMTQsIDIwMTUgYXQgMDQ6MDg6NDRQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IENvbnZlcnQgdGhlIGJvLWNhY2hlIGludG8gMiBwaGFzZXM6Cj4gCj4gMS4gQSB0d28g c2Vjb25kIGNhY2hlIG9mIHJlY2VudGx5IHVzZWQgYnVmZmVycywga2VlcCB1bnRvdWNoZWQuCj4g Mi4gQSB0d28gc2Vjb25kIGNhY2hlIG9mIG9sZGVyIGJ1ZmZlcnMsIG1hcmtlZCBmb3IgZXZpY3Rp b24uCj4gCj4gVGhpcyBoZWxwcyByZWR1Y2UgaW9jdGwgdHJhZmZpYyBvbiBhIHJhcGlkIHR1cm5v dmVyIGluIHdvcmtpbmcgc2V0cy4gVGhlCj4gaXNzdWUgaXMgdGhhdCBldmVuIGEgMiBzZWNvbmQg d2luZG93IGlzIGVub3VnaCBmb3IgYW4gYXBwbGljYXRpb24gdG8KPiBmaWxsIGFsbCBvZiBtZW1v cnkgd2l0aCBpbmFjdGl2ZSBidWZmZXJzIChhbmQgd2Ugd291bGQgcmVseSBvbiB0aGUKPiBvb20t a2lsbGVyIGlkZW50aWZ5aW5nIHRoZSByaWdodCBjdWxwcml0KS4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogRGFuaWVsIFZl dHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogQmVuIFdpZGF3c2t5IDxiZW5qYW1p bi53aWRhd3NreUBpbnRlbC5jb20+Cj4gLS0tCj4gIGludGVsL2ludGVsX2J1Zm1ncl9nZW0uYyB8 IDQyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUg Y2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvaW50ZWwvaW50ZWxfYnVmbWdyX2dlbS5jIGIvaW50ZWwvaW50ZWxfYnVmbWdyX2dlbS5jCj4g aW5kZXggZjVkNjEzMC4uZWNiZjhlZSAxMDA2NDQKPiAtLS0gYS9pbnRlbC9pbnRlbF9idWZtZ3Jf Z2VtLmMKPiArKysgYi9pbnRlbC9pbnRlbF9idWZtZ3JfZ2VtLmMKPiBAQCAtMjExLDYgKzIxMSwx MSBAQCBzdHJ1Y3QgX2RybV9pbnRlbF9ib19nZW0gewo+ICAJYm9vbCB1c2VkX2FzX3JlbG9jX3Rh cmdldDsKPiAgCj4gIAkvKioKPiArCSAqIEFyZSB3ZSBrZWVwaW5nIHRoaXMgYnVmZmVyIGFyb3Vu ZCBpbiBzZW1pLXBlcm1lbmFudCBjYWNoZT8KPiArCSAqLwo+ICsJYm9vbCBkb250bmVlZDsKPiAr Cj4gKwkvKioKPiAgCSAqIEJvb2xlYW4gb2Ygd2hldGhlciB3ZSBoYXZlIGVuY291bnRlcmVkIGFu IGVycm9yIHdoaWxzdCBidWlsZGluZyB0aGUgcmVsb2NhdGlvbiB0cmVlLgo+ICAJICovCj4gIAli b29sIGhhc19lcnJvcjsKPiBAQCAtNzE0LDcgKzcxOSw4IEBAIHJldHJ5Ogo+ICAJCX0KPiAgCj4g IAkJaWYgKGFsbG9jX2Zyb21fY2FjaGUpIHsKPiAtCQkJaWYgKCFkcm1faW50ZWxfZ2VtX2JvX21h ZHZpc2VfaW50ZXJuYWwKPiArCQkJaWYgKGJvX2dlbS0+ZG9udG5lZWQgJiYKPiArCQkJICAgICFk cm1faW50ZWxfZ2VtX2JvX21hZHZpc2VfaW50ZXJuYWwKPiAgCQkJICAgIChidWZtZ3JfZ2VtLCBi b19nZW0sIEk5MTVfTUFEVl9XSUxMTkVFRCkpIHsKPiAgCQkJCWRybV9pbnRlbF9nZW1fYm9fZnJl ZSgmYm9fZ2VtLT5ibyk7Cj4gIAkJCQlkcm1faW50ZWxfZ2VtX2JvX2NhY2hlX3B1cmdlX2J1Y2tl dChidWZtZ3JfZ2VtLAo+IEBAIC0xMTUwLDYgKzExNTYsMjAgQEAgZHJtX2ludGVsX2dlbV9ib19t YXJrX21tYXBzX2luY29oZXJlbnQoZHJtX2ludGVsX2JvICpibykKPiAgI2VuZGlmCj4gIH0KPiAg Cj4gK3N0YXRpYyBpbmxpbmUgdm9pZCBfX3NwbGljZShjb25zdCBkcm1NTUxpc3RIZWFkICpsaXN0 LAo+ICsJCQkgICAgZHJtTU1MaXN0SGVhZCAqcHJldiwKPiArCQkJICAgIGRybU1NTGlzdEhlYWQg Km5leHQpCj4gK3sKPiArCWRybU1NTGlzdEhlYWQgKmZpcnN0ID0gbGlzdC0+bmV4dDsKPiArCWRy bU1NTGlzdEhlYWQgKmxhc3QgPSBsaXN0LT5wcmV2Owo+ICsKPiArCWZpcnN0LT5wcmV2ID0gcHJl djsKPiArCXByZXYtPm5leHQgPSBmaXJzdDsKPiArCj4gKwlsYXN0LT5uZXh0ID0gbmV4dDsKPiAr CW5leHQtPnByZXYgPSBsYXN0Owo+ICt9Cj4gKwoKU2VlbXMgd29ydGggYWRkaW5nIHRvIGxpYmRy bV9saXN0cy5oCgo+ICAvKiogRnJlZXMgYWxsIGNhY2hlZCBidWZmZXJzIHNpZ25pZmljYW50bHkg b2xkZXIgdGhhbiBAdGltZS4gKi8KPiAgc3RhdGljIHZvaWQKPiAgZHJtX2ludGVsX2dlbV9jbGVh bnVwX2JvX2NhY2hlKGRybV9pbnRlbF9idWZtZ3JfZ2VtICpidWZtZ3JfZ2VtLCB0aW1lX3QgdGlt ZSkKPiBAQCAtMTE2MiwxOSArMTE4MiwyOSBAQCBkcm1faW50ZWxfZ2VtX2NsZWFudXBfYm9fY2Fj aGUoZHJtX2ludGVsX2J1Zm1ncl9nZW0gKmJ1Zm1ncl9nZW0sIHRpbWVfdCB0aW1lKQo+ICAJZm9y IChpID0gMDsgaSA8IGJ1Zm1ncl9nZW0tPm51bV9idWNrZXRzOyBpKyspIHsKPiAgCQlzdHJ1Y3Qg ZHJtX2ludGVsX2dlbV9ib19idWNrZXQgKmJ1Y2tldCA9Cj4gIAkJICAgICZidWZtZ3JfZ2VtLT5j YWNoZV9idWNrZXRbaV07Cj4gKwkJZHJtTU1MaXN0SGVhZCBtYWR2Owo+ICAKPiArCQlEUk1JTklU TElTVEhFQUQoJm1hZHYpOwo+ICAJCXdoaWxlICghRFJNTElTVEVNUFRZKCZidWNrZXQtPmhlYWQp KSB7Cj4gIAkJCWRybV9pbnRlbF9ib19nZW0gKmJvX2dlbTsKPiAgCj4gIAkJCWJvX2dlbSA9IERS TUxJU1RFTlRSWShkcm1faW50ZWxfYm9fZ2VtLAo+ICAJCQkJCSAgICAgIGJ1Y2tldC0+aGVhZC5u ZXh0LCBoZWFkKTsKPiAtCQkJaWYgKHRpbWUgLSBib19nZW0tPmZyZWVfdGltZSA8PSAxKQo+ICsJ CQlpZiAodGltZSAtIGJvX2dlbS0+ZnJlZV90aW1lIDwgMiooMStib19nZW0tPmRvbnRuZWVkKSkK ClNvbWV0aGluZyBzb21ld2hlcmUgd2lsbCBjb21wbGFpbiBhYm91dCBtaXhpbmcgYm9vbHMgYW5k IGludHMsIEknZCBndWVzcy4KCkFsc28gcGVyaGFwcyBmb3IgcGVyZiBiaXNlY3Rpb24gbWF5YmUg ZG8gYSBwYXRjaCBiZWZvcmUgdGhpcyBjaGFuZ2luZyB0aGUKZXhwaXJhdGlvbiB0aW1lIHRvIDIg KG9yIDQpLCB0aGVuIGFkZCB0aGUgZXh0cmEgZG9udG5lZWQgc3RhdGU/Cgo+ICAJCQkJYnJlYWs7 Cj4gIAo+ICAJCQlEUk1MSVNUREVMKCZib19nZW0tPmhlYWQpOwo+IC0KPiAtCQkJZHJtX2ludGVs X2dlbV9ib19mcmVlKCZib19nZW0tPmJvKTsKPiArCQkJaWYgKGJvX2dlbS0+ZG9udG5lZWQpIHsK PiArCQkJCWRybV9pbnRlbF9nZW1fYm9fZnJlZSgmYm9fZ2VtLT5ibyk7Cj4gKwkJCX0gZWxzZSB7 Cj4gKwkJCQlkcm1faW50ZWxfZ2VtX2JvX21hZHZpc2VfaW50ZXJuYWwoYnVmbWdyX2dlbSwgYm9f Z2VtLAo+ICsJCQkJCQkJCSAgSTkxNV9NQURWX0RPTlRORUVEKTsKPiArCQkJCWJvX2dlbS0+ZG9u dG5lZWQgPSAxOwo+ICsJCQkJRFJNTElTVEFERFRBSUwoJmJvX2dlbS0+aGVhZCwgJm1hZHYpOwo+ ICsJCQl9Cj4gIAkJfQoKTWF5YmUgYWRkIGEgY29tbWVudCBoZXJlPwovKiBPYmplY3RzIHdoaWNo IGhhdmUgZWxhcHNlZCAycyBvZiBkaXN1c2Ugc2hvdWxkIGdvIHRvIHRoZSB0b3Agb2YgdGhlIGJ1 Y2tldC4gKi8KCj4gKwkJaWYgKCFEUk1MSVNURU1QVFkoJm1hZHYpKQo+ICsJCQlfX3NwbGljZSgm bWFkdiwgJmJ1Y2tldC0+aGVhZCwgYnVja2V0LT5oZWFkLm5leHQpOwoKCj4gIAl9Cj4gIAo+ICAJ YnVmbWdyX2dlbS0+dGltZSA9IHRpbWU7Cj4gQEAgLTEyODUsOSArMTMxNSw3IEBAIGRybV9pbnRl bF9nZW1fYm9fdW5yZWZlcmVuY2VfZmluYWwoZHJtX2ludGVsX2JvICpibywgdGltZV90IHRpbWUp Cj4gIAo+ICAJYnVja2V0ID0gZHJtX2ludGVsX2dlbV9ib19idWNrZXRfZm9yX3NpemUoYnVmbWdy X2dlbSwgYm8tPnNpemUpOwo+ICAJLyogUHV0IHRoZSBidWZmZXIgaW50byBvdXIgaW50ZXJuYWwg Y2FjaGUgZm9yIHJldXNlIGlmIHdlIGNhbi4gKi8KPiAtCWlmIChidWZtZ3JfZ2VtLT5ib19yZXVz ZSAmJiBib19nZW0tPnJldXNhYmxlICYmIGJ1Y2tldCAhPSBOVUxMICYmCj4gLQkgICAgZHJtX2lu dGVsX2dlbV9ib19tYWR2aXNlX2ludGVybmFsKGJ1Zm1ncl9nZW0sIGJvX2dlbSwKPiAtCQkJCQkg ICAgICBJOTE1X01BRFZfRE9OVE5FRUQpKSB7Cj4gKwlpZiAoYnVmbWdyX2dlbS0+Ym9fcmV1c2Ug JiYgYm9fZ2VtLT5yZXVzYWJsZSAmJiBidWNrZXQgIT0gTlVMTCkgewo+ICAJCWJvX2dlbS0+ZnJl ZV90aW1lID0gdGltZTsKPiAgCj4gIAkJYm9fZ2VtLT5uYW1lID0gTlVMTDsKCkluIGdlbmVyYWws IGl0IGxvb2tzIGZpbmUgdG8gbWUuIExpa2UgSSBzYWlkIGFib3ZlIHdydCBhZGRpbmcgdGhlIHBh dGNoIGJlZm9yZQp0aGlzLCBJIGFtIGN1cmlvdXMgaG93IG11Y2ggZGlmZmVyZW5jZSB5b3Ugc2Vl IGp1c3QgbWVzc2luZyB3aXRoIHRoZSBleHBpcmF0aW9uCnRpbWVzIHZlcnN1cyB0aGUgdHdvIHN0 YXRlIG1vZGVsLgoKLS0gCkJlbiBXaWRhd3NreSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9n eSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK