From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YiFgh-0002vK-7D for mharc-grub-devel@gnu.org; Wed, 15 Apr 2015 01:16:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiFgd-0002u0-PO for grub-devel@gnu.org; Wed, 15 Apr 2015 01:16:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiFgZ-000066-T2 for grub-devel@gnu.org; Wed, 15 Apr 2015 01:16:31 -0400 Received: from mail-la0-x236.google.com ([2a00:1450:4010:c03::236]:34562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiFgZ-000061-LT for grub-devel@gnu.org; Wed, 15 Apr 2015 01:16:27 -0400 Received: by laat2 with SMTP id t2so24242525laa.1 for ; Tue, 14 Apr 2015 22:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=6o6BG+H0P6w9N+nxs+YDpH1neO9OhSfK3/u5cZ5qz4o=; b=RlQsj+M96a+MjqHK1ZVtSjQ/8UV0MrHmC3AAZF18uQ4B/kNyJltsTssh4VQBELcX81 hrmgObtsw6YoNlAsB0YIkE2cIU3BHqFYojETqu79FuedZ9YkavYIrraDhcKnbzXOgH81 6qcONGOH3MLY5QjNI3zY/jvUlSyaMe6A2IN8YSmWm0VKrJ0AfELBfzTWF428aCm0KwxR l/2VpxHwr9Z05xzJu2RSBh15qLGb2V0OUYpn9JddNCvrlz4lGgjyBx2KaWRvTqcHv7gm GYDA9uh8nRYITO0T9/9cmNeEK6AqMSH2cdfM3JgRM8kGiOrhF6ibfOUMRglAXXNSM7Tz Z1Wg== X-Received: by 10.112.140.74 with SMTP id re10mr22282785lbb.80.1429074986574; Tue, 14 Apr 2015 22:16:26 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id je5sm677184lac.33.2015.04.14.22.16.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Apr 2015 22:16:25 -0700 (PDT) Date: Wed, 15 Apr 2015 08:16:24 +0300 From: Andrei Borzenkov To: Toomas Soome Subject: Re: [PATCH] grub-core/lib/libgcrypt/cipher/rijndael.c 2 warnings. Message-ID: <20150415081624.6014914d@opensuse.site> In-Reply-To: References: <7D74EDB8-7B51-4E03-BD9C-61F77B5E064C@me.com> <20150413195658.4f27ea42@opensuse.site> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::236 Cc: The development of GRUB 2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 05:16:32 -0000 =D0=92 Mon, 13 Apr 2015 20:32:53 +0300 Toomas Soome =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > hi! >=20 > just checked the git://git.gnupg.org/libgcrypt.git - apparently it has b= een changed compared to one included in grub; the int i versus unsigned key= len is still there (visual inspection), the { } were inserted to if (0) ; = statement.=20 >=20 > so second half is already fixed. I did report the signed/unsigned compar= e issue to gcrypt-devel, but then the question is about updating libcgrypt = in grub;=20 It gets updated every now and then. "Upstream first" makes sure that if we add local patch it won't be lost next time library is pulled in. Just to be sure - these are just warnings, right? They do not cause build failure or any regression?