From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Wed, 15 Apr 2015 14:04:04 +0200 Subject: [U-Boot] [PATCH] net: Use u32 instead of ulong for transaction ID in bootp In-Reply-To: References: Message-ID: <20150415120403.GJ20875@ulmo.nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Apr 15, 2015 at 12:50:59PM +0200, Michal Simek wrote: > From: Siva Durga Prasad Paladugu > > Based on rfc951 transaction ID has 4 bytes which is not the case when > ulong type is used on ARM64. > Use u32 type which is well defined for all archs. > > BOOTP_VENDOR_MAGIC is also 4 bytes. > > Based on RFC1048 Time Offset (code 2) is also 4bytes long > and IP Address Lease Time also. > > The patch converts NetCopyLong to netcopy32 and NetReadLong to netread32 > to follow u-boot coding style. > > Signed-off-by: Siva Durga Prasad Paladugu > Signed-off-by: Michal Simek > --- > > include/net.h | 14 +++++++------- > net/bootp.c | 18 +++++++++--------- > net/bootp.h | 2 +- > 3 files changed, 17 insertions(+), 17 deletions(-) Looks reasonable to me: Reviewed-by: Thierry Reding -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: