From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Murray <murrayie@yahoo.co.uk>, xen-devel@lists.xen.org
Subject: Re: [PATCH v5 3/7] libxl/libxl_domain_info: Log if domain not found.
Date: Wed, 15 Apr 2015 09:56:03 -0400 [thread overview]
Message-ID: <20150415135603.GF31387@l.oracle.com> (raw)
In-Reply-To: <1429104658.15516.288.camel@citrix.com>
On Wed, Apr 15, 2015 at 02:30:58PM +0100, Ian Campbell wrote:
> On Wed, 2015-04-15 at 14:03 +0100, Ian Campbell wrote:
> > On Mon, 2015-04-06 at 09:32 -0400, Konrad Rzeszutek Wilk wrote:
> > > Ian C, thoughts? Just ditch this patch?
> >
> > I think so, my original suggestion to include the logging was predicated
> > on it not being usual for us to look up a non-existent domid, but the xl
> > domid usecase was one which didn't occur, and is a very valid reason not
> > to do this.
> >
> > Alternatively could crank the log level all the way down to DEBUG, I'm
> > happy either way (at least until someone tells me why I'm not!).
>
> I realised that having acked #2 everything was acked, so I've applied
> without this one, if you want to go the debug log route then please
> could you send that separately?
Thank you for applying them!
Lets ignore the debug log route.
>
> Ian.
>
next prev parent reply other threads:[~2015-04-15 13:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 20:02 [PATCH v5] Fix xl vcpu-set to decrrease an guest vCPU amount without complaints Konrad Rzeszutek Wilk
2015-04-03 20:02 ` [PATCH v5 1/7] libxl: Add ERROR_DOMAIN_NOTFOUND for libxl_domain_info when it cannot find the domain Konrad Rzeszutek Wilk
2015-04-03 20:02 ` [PATCH v5 2/7] libxl: In libxl_set_vcpuonline check for maximum number of VCPUs against the cpumap Konrad Rzeszutek Wilk
2015-04-15 13:01 ` Ian Campbell
2015-04-03 20:02 ` [PATCH v5 3/7] libxl/libxl_domain_info: Log if domain not found Konrad Rzeszutek Wilk
2015-04-03 22:12 ` Ian Murray
2015-04-06 13:32 ` Konrad Rzeszutek Wilk
2015-04-15 13:03 ` Ian Campbell
2015-04-15 13:30 ` Ian Campbell
2015-04-15 13:56 ` Konrad Rzeszutek Wilk [this message]
2015-04-15 13:55 ` Konrad Rzeszutek Wilk
2015-04-03 20:02 ` [PATCH v5 4/7] libxl/vcpuset: Print error if libxl_set_vcpuonline returns ERROR_DOMAIN_NOTFOUND Konrad Rzeszutek Wilk
2015-04-03 20:02 ` [PATCH v5 5/7] libxl/vcpuset: Return error value if failed Konrad Rzeszutek Wilk
2015-04-03 20:02 ` [PATCH v5 6/7] libxl/vcpuset: Remove useless limit on max_vcpus Konrad Rzeszutek Wilk
2015-04-03 20:02 ` [PATCH v5 7/7] libxl/vcpu-set - allow to decrease vcpu count on overcommitted guests (v5) Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415135603.GF31387@l.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=murrayie@yahoo.co.uk \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.