From: Jeff King <peff@peff.net>
To: Matthew Rothenberg <mroth@khanacademy.org>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: PATH modifications for git-hook processes
Date: Thu, 16 Apr 2015 02:31:37 -0400 [thread overview]
Message-ID: <20150416063137.GA7761@peff.net> (raw)
In-Reply-To: <20150416061732.GA5612@peff.net>
On Thu, Apr 16, 2015 at 02:17:32AM -0400, Jeff King wrote:
> So it uses a special git-specific version of exec, and doesn't touch the
> PATH. Later, we did 231af83 (Teach the "git" command to handle some
> commands internally, 2006-02-26), which says at the end:
>
> There's one other change: the search order for external programs is
> modified slightly, so that the first entry remains GIT_EXEC_DIR, but
> the second entry is the same directory as the git wrapper itself was
> executed out of - if we can figure it out from argv[0], of course.
>
> There was some question of whether this would be a problem[1], but we
> realized it is OK due to 77cb17e, mentioned above.
I forgot to include my footnote, which was a link to the thread:
http://thread.gmane.org/gmane.comp.version-control.git/16798
-Peff
next prev parent reply other threads:[~2015-04-16 6:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 16:04 PATH modifications for git-hook processes Matthew Rothenberg
2015-04-14 17:17 ` Junio C Hamano
2015-04-15 15:00 ` Matthew Rothenberg
2015-04-16 6:17 ` Jeff King
2015-04-16 6:31 ` Jeff King [this message]
2015-04-22 0:39 ` David Rodríguez
2015-04-22 17:46 ` Junio C Hamano
2015-04-22 18:14 ` [PATCH] stop putting argv[0] dirname at front of PATH Jeff King
2015-04-22 18:23 ` Eric Sunshine
2015-04-22 18:36 ` Jeff King
2015-04-22 19:23 ` Jonathan Nieder
2015-04-22 20:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416063137.GA7761@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mroth@khanacademy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.