From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sre@kernel.org>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
linux-leds@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v8 1/1] media: i2c/adp1653: Devicetree support for adp1653
Date: Thu, 16 Apr 2015 21:22:35 +0200 [thread overview]
Message-ID: <20150416192235.GA8188@amd> (raw)
In-Reply-To: <20150416162905.GA3181@earth>
Hi!
> > > This will reduce complexity in the driver and should be fairly easy
> > > to implement, since there is no adp1653 platform code user in the
> > > mainline kernel anyways.
> >
> > I'd hate to break out of tree users for very little gain.
...
> So let's have a look at the advantages of removing the power gpio:
One change per patch. My change did what it said, "add a device tree
support", if you want to do second change "break existing interface",
feel free doing it as a separate patch.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-04-16 19:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 23:37 [PATCH v8 1/1] media: i2c/adp1653: Devicetree support for adp1653 Sakari Ailus
2015-04-16 5:24 ` Sebastian Reichel
2015-04-16 5:58 ` Pavel Machek
2015-04-16 16:29 ` Sebastian Reichel
2015-04-16 16:29 ` Sebastian Reichel
2015-04-16 19:22 ` Pavel Machek [this message]
2015-04-16 20:22 ` Sakari Ailus
2015-04-16 20:22 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416192235.GA8188@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.