All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 7/7] colibri_vf: Enable USB support for Colibri Vybrid
Date: Fri, 17 Apr 2015 11:30:36 +0200	[thread overview]
Message-ID: <201504171130.37042.marex@denx.de> (raw)
In-Reply-To: <20150417092103.GA5646@Sanchayan-Arch.toradex.int>

On Friday, April 17, 2015 at 11:21:03 AM, maitysanchayan at gmail.com wrote:
> Hello,
> 
> On 15-04-16 22:21:11, Marek Vasut wrote:
> > On Wednesday, April 15, 2015 at 12:54:28 PM, Sanchayan Maity wrote:
> > > Enable USB support on Toradex Colibri Vybrid Modules.
> > > 
> > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > > ---
> > > 
> > >  board/toradex/colibri_vf/colibri_vf.c | 25 +++++++++++++++++++++--
> > >  include/configs/colibri_vf.h          | 37
> > > 
> > > +++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+),
> > > 2 deletions(-)
> > > 
> > > diff --git a/board/toradex/colibri_vf/colibri_vf.c
> > > b/board/toradex/colibri_vf/colibri_vf.c index e7bc6c1..054e6f9 100644
> > > --- a/board/toradex/colibri_vf/colibri_vf.c
> > > +++ b/board/toradex/colibri_vf/colibri_vf.c
> > > @@ -197,7 +197,8 @@ static void clock_init(void)
> > > 
> > >  	clrsetbits_le32(&ccm->ccgr0, CCM_REG_CTRL_MASK,
> > >  	
> > >  			CCM_CCGR0_UART0_CTRL_MASK);
> > >  	
> > >  	clrsetbits_le32(&ccm->ccgr1, CCM_REG_CTRL_MASK,
> > > 
> > > -			CCM_CCGR1_PIT_CTRL_MASK | CCM_CCGR1_WDOGA5_CTRL_MASK);
> > > +			CCM_CCGR1_PIT_CTRL_MASK | CCM_CCGR1_WDOGA5_CTRL_MASK |
> > > +			CCM_CCGR1_USBC0_CTRL_MASK);
> > 
> > You probably want to flip these CCM regs only if CONFIG_CI_UDC is enabled
> > or something along those lines, right ?
> 
> Yes, that would be be better. Will send a new corrected patch for this.
> I assume since there are no issues with the rest of the patchset so
> sending a respin of this last patch would do?!
> 
> Thanks for the feedback and catching this.

Yup, resending just the last patch is fine :)

Best regards,
Marek Vasut

  reply	other threads:[~2015-04-17  9:30 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 10:54 [U-Boot] [PATCH v3 0/7] Add support for Colibri Vybrid Modules Sanchayan Maity
2015-04-15 10:54 ` [U-Boot] [PATCH v3 1/7] ARM: vf610: Move DDR3 initialization to imx-common Sanchayan Maity
2015-04-23 22:03   ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-04-15 10:54 ` [U-Boot] [PATCH v3 2/7] ARM: vf610: Enable external 32KHz oscillator Sanchayan Maity
2015-04-23 22:03   ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-04-15 10:54 ` [U-Boot] [PATCH v3 3/7] ARM: vf610: Add SoC and CPU type detection Sanchayan Maity
2015-04-23 22:04   ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-04-15 10:54 ` [U-Boot] [PATCH v3 4/7] ARM: vf610: Enable caches Sanchayan Maity
2015-04-23 22:04   ` [U-Boot] [U-Boot,v3,4/7] " Tom Rini
2015-04-15 10:54 ` [U-Boot] [PATCH v3 5/7] ARM: vf610: Initial integration for Colibri VF50/VF61 Sanchayan Maity
2015-04-16  6:36   ` Stefan Agner
2015-04-23 22:04   ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-04-15 10:54 ` [U-Boot] [PATCH v3 6/7] usb: host: Add ehci-vf USB driver for ARM Vybrid SoC's Sanchayan Maity
2015-04-23 22:04   ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-04-15 10:54 ` [U-Boot] [PATCH v3 7/7] colibri_vf: Enable USB support for Colibri Vybrid Sanchayan Maity
2015-04-16 20:21   ` Marek Vasut
2015-04-17  9:21     ` maitysanchayan at gmail.com
2015-04-17  9:30       ` Marek Vasut [this message]
2015-04-17 13:26         ` [U-Boot] [PATCH v4 " Sanchayan Maity
2015-04-17 20:16           ` Marek Vasut
2015-04-23 22:04           ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-04-23 12:38 ` [U-Boot] [PATCH v3 0/7] Add support for Colibri Vybrid Modules maitysanchayan at gmail.com
2015-04-23 13:13   ` Tom Rini
2015-04-23 21:13     ` Marek Vasut
2015-04-27 17:54       ` Tom Rini
2015-04-27 18:18         ` Marek Vasut
2015-04-27 20:00           ` Otavio Salvador
2015-04-27 21:39             ` Marek Vasut
2015-04-27 20:02         ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201504171130.37042.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.