From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 17 Apr 2015 12:24:08 +0000 Subject: [patch] drm/gma500: missing error codes in psb_driver_load() Message-Id: <20150417122408.GA19623@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Airlie Cc: Thierry Reding , Daniel Vetter , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Benoit Taine , Dave Airlie We should return an error code here. In the current code they can only fail if there is an allocation error so -ENOMEM is appropriate. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c index 92e7e57..4eff0d6 100644 --- a/drivers/gpu/drm/gma500/psb_drv.c +++ b/drivers/gpu/drm/gma500/psb_drv.c @@ -326,12 +326,16 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags) goto out_err; dev_priv->mmu = psb_mmu_driver_init(dev, 1, 0, 0); - if (!dev_priv->mmu) + if (!dev_priv->mmu) { + ret = -ENOMEM; goto out_err; + } dev_priv->pf_pd = psb_mmu_alloc_pd(dev_priv->mmu, 1, 0); - if (!dev_priv->pf_pd) + if (!dev_priv->pf_pd) { + ret = -ENOMEM; goto out_err; + } ret = psb_do_init(dev); if (ret) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/gma500: missing error codes in psb_driver_load() Date: Fri, 17 Apr 2015 15:24:08 +0300 Message-ID: <20150417122408.GA19623@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by gabe.freedesktop.org (Postfix) with ESMTP id E6FC46EB4E for ; Fri, 17 Apr 2015 05:24:41 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: David Airlie Cc: Thierry Reding , Daniel Vetter , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Benoit Taine , Dave Airlie List-Id: dri-devel@lists.freedesktop.org V2Ugc2hvdWxkIHJldHVybiBhbiBlcnJvciBjb2RlIGhlcmUuICBJbiB0aGUgY3VycmVudCBjb2Rl IHRoZXkgY2FuIG9ubHkKZmFpbCBpZiB0aGVyZSBpcyBhbiBhbGxvY2F0aW9uIGVycm9yIHNvIC1F Tk9NRU0gaXMgYXBwcm9wcmlhdGUuCgpTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4u Y2FycGVudGVyQG9yYWNsZS5jb20+CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2dtYTUw MC9wc2JfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL3BzYl9kcnYuYwppbmRleCA5MmU3 ZTU3Li40ZWZmMGQ2IDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL3BzYl9kcnYu YworKysgYi9kcml2ZXJzL2dwdS9kcm0vZ21hNTAwL3BzYl9kcnYuYwpAQCAtMzI2LDEyICszMjYs MTYgQEAgc3RhdGljIGludCBwc2JfZHJpdmVyX2xvYWQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwg dW5zaWduZWQgbG9uZyBmbGFncykKIAkJZ290byBvdXRfZXJyOwogCiAJZGV2X3ByaXYtPm1tdSA9 IHBzYl9tbXVfZHJpdmVyX2luaXQoZGV2LCAxLCAwLCAwKTsKLQlpZiAoIWRldl9wcml2LT5tbXUp CisJaWYgKCFkZXZfcHJpdi0+bW11KSB7CisJCXJldCA9IC1FTk9NRU07CiAJCWdvdG8gb3V0X2Vy cjsKKwl9CiAKIAlkZXZfcHJpdi0+cGZfcGQgPSBwc2JfbW11X2FsbG9jX3BkKGRldl9wcml2LT5t bXUsIDEsIDApOwotCWlmICghZGV2X3ByaXYtPnBmX3BkKQorCWlmICghZGV2X3ByaXYtPnBmX3Bk KSB7CisJCXJldCA9IC1FTk9NRU07CiAJCWdvdG8gb3V0X2VycjsKKwl9CiAKIAlyZXQgPSBwc2Jf ZG9faW5pdChkZXYpOwogCWlmIChyZXQpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vZHJpLWRldmVsCg==