From: Jiri Olsa <jolsa@redhat.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: linux-kernel@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] perf: Ensure symbols for plugins are exported
Date: Fri, 17 Apr 2015 17:34:30 +0200 [thread overview]
Message-ID: <20150417153430.GF17654@krava> (raw)
In-Reply-To: <1428854451-28361-1-git-send-email-minipli@googlemail.com>
On Sun, Apr 12, 2015 at 06:00:51PM +0200, Mathias Krause wrote:
> When building perf with perl or python support it implicitly gets linked
> with the -export-dynamic linker option through the additional linker
> flags, namely with -Wl,-E via perl or -Xlinker -export-dynamic via
> python. That flag is essential for the traceevent plugin support so we
> shouldn't rely on adding it implicitly.
>
> Ensure perf's exported symbols can be used by dlopen()ed plugins by
> unconditionally adding this flag when linking perf. Otherwise plugins
> won't be able to access symbols in the perf binary.
>
> This fixes the following warning / bug when trying to load plugins:
>
> Warning: could not load plugin '/home/minipli/.traceevent/plugins/plugin_xen.so'
> /home/minipli/.traceevent/plugins/plugin_xen.so: undefined symbol: trace_seq_printf
> Warning: could not load plugin '/home/minipli/.traceevent/plugins/plugin_function.so'
> /home/minipli/.traceevent/plugins/plugin_function.so: undefined symbol: warning
> Warning: could not load plugin '/home/minipli/.traceevent/plugins/plugin_sched_switch.so'
> /home/minipli/.traceevent/plugins/plugin_sched_switch.so: undefined symbol: pevent_unregister_event_handler
> [...]
hum, not sure now how -export-dynamic works but should this
be rather in traceevent lib then?
jirka
next prev parent reply other threads:[~2015-04-17 15:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 16:00 [PATCH] perf: Ensure symbols for plugins are exported Mathias Krause
2015-04-17 15:34 ` Jiri Olsa [this message]
2015-04-17 21:01 ` Mathias Krause
2015-04-18 15:46 ` Jiri Olsa
2015-04-22 20:12 ` Mathias Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417153430.GF17654@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.