From: Vinod Koul <vinod.koul@intel.com>
To: Niklas Cassel <niklas.cassel@axis.com>
Cc: ludovic.desroches@atmel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, Niklas Cassel <niklass@axis.com>
Subject: Re: [PATCH] dmaengine: at_xdmac: unlock spin lock before return
Date: Fri, 17 Apr 2015 23:39:59 +0530 [thread overview]
Message-ID: <20150417180959.GI30624@intel.com> (raw)
In-Reply-To: <1428417765-16910-1-git-send-email-niklass@axis.com>
On Tue, Apr 07, 2015 at 04:42:45PM +0200, Niklas Cassel wrote:
> Signed-off-by: Niklas Cassel <niklass@axis.com>
> ---
> drivers/dma/at_xdmac.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index d9891d3..933e4b3 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1154,8 +1154,10 @@ static int at_xdmac_device_resume(struct dma_chan *chan)
> dev_dbg(chan2dev(chan), "%s\n", __func__);
>
> spin_lock_bh(&atchan->lock);
> - if (!at_xdmac_chan_is_paused(atchan))
> + if (!at_xdmac_chan_is_paused(atchan)) {
> + spin_unlock_bh(&atchan->lock);
> return 0;
> + }
>
> at_xdmac_write(atxdmac, AT_XDMAC_GRWR, atchan->mask);
> clear_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
> --
> 2.1.4
>
Applied now
--
~Vinod
prev parent reply other threads:[~2015-04-17 18:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 14:42 [PATCH] dmaengine: at_xdmac: unlock spin lock before return Niklas Cassel
2015-04-10 13:49 ` Ludovic Desroches
2015-04-17 18:09 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417180959.GI30624@intel.com \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=niklas.cassel@axis.com \
--cc=niklass@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.