From: Vinod Koul <vinod.koul@intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de, lgirdwood@gmail.com,
Omair M Abdullah <omair.m.abdullah@intel.com>,
broonie@kernel.org, Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH v2 7/7] ASoC: hda - added Skylake I2S machine driver
Date: Sat, 18 Apr 2015 00:36:55 +0530 [thread overview]
Message-ID: <20150417190655.GO30624@intel.com> (raw)
In-Reply-To: <5530D612.4000109@metafoo.de>
On Fri, Apr 17, 2015 at 11:44:50AM +0200, Lars-Peter Clausen wrote:
> On 04/17/2015 11:13 AM, Vinod Koul wrote:
> [...]
> >+ /* always connected - check HP for jack detect */
> >+ snd_soc_dapm_enable_pin(dapm, "Headphone Jack");
> >+ snd_soc_dapm_enable_pin(dapm, "Speaker");
> >+ snd_soc_dapm_enable_pin(dapm, "Mic Jack");
> >+ snd_soc_dapm_enable_pin(dapm, "DMIC2");
>
> There is no need to do this, all pins are enabled by default.
Ah yes, thanks for pointing. With this I should also set full_routed right?
--
~Vinod
next prev parent reply other threads:[~2015-04-17 19:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 9:13 [PATCH v2 0/7] ASoC: hda - add ASoC Skylake HD audio driver Vinod Koul
2015-04-17 9:13 ` [PATCH v2 1/7] ALSA: hda - add ASoC device type for hda core Vinod Koul
2015-04-17 9:13 ` [PATCH v2 2/7] ALSA: hda - add generic functions to set hdac stream params Vinod Koul
2015-04-17 9:39 ` Takashi Iwai
2015-04-17 11:33 ` Vinod Koul
2015-04-17 9:13 ` [PATCH v2 3/7] ASoC: hda - add soc hda codec driver wrapper Vinod Koul
2015-04-17 9:42 ` Takashi Iwai
2015-04-17 11:34 ` Vinod Koul
2015-04-17 9:13 ` [PATCH v2 4/7] ASoC: hda - add Skylake platform driver Vinod Koul
2015-04-17 9:57 ` Takashi Iwai
2015-04-17 11:47 ` Takashi Iwai
2015-04-17 11:51 ` Vinod Koul
2015-04-17 9:13 ` [PATCH v2 5/7] ASoC: hda - add Skylake HD audio driver Vinod Koul
2015-04-17 10:06 ` Takashi Iwai
2015-04-17 12:02 ` Vinod Koul
2015-04-19 7:27 ` Takashi Iwai
2015-04-22 3:01 ` Vinod Koul
2015-04-17 9:13 ` [PATCH v2 6/7] ASoC: hda - enable ASoC " Vinod Koul
2015-04-17 9:13 ` [PATCH v2 7/7] ASoC: hda - added Skylake I2S machine driver Vinod Koul
2015-04-17 9:44 ` Lars-Peter Clausen
2015-04-17 19:06 ` Vinod Koul [this message]
2015-04-17 19:14 ` Lars-Peter Clausen
2015-04-22 3:00 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417190655.GO30624@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=omair.m.abdullah@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.