Re: [PATCH 2/2] perf tools: Add a option 'remove' to perf-config and features which get or set a config variable.

[Namhyung Kim <namhyung@kernel.org>]

On Sat, Apr 18, 2015 at 02:02:17PM +0900, Taewoong Song wrote:
> > On Apr 13, 2015, at 3:55 PM, Namhyung Kim <namhyung@kernel.org> wrote:
> > On Sun, Apr 12, 2015 at 11:44:49PM +0900, Taeung Song wrote:
> >> +static struct config_section *find_config_section(const char *section_name)
> >> +{
> >> +	struct config_section *section_node;
> > 
> > It'd be better to split declaration and function body with a blank line.
> > 
> 
> Does mean it like followed by ?
> 
> +static struct config_section *find_config_section(const char *section_name)
> +
> +{
> +	struct config_section *section_node;
> 
> ,or is it ?  
> 
> +static struct config_section *find_config_section(const char *section_name)
> +{
> +
> +	struct config_section *section_node;

Nope!  I meant

static struct config_section *find_config_section(const char *section_name)
{
	struct config_section *section node
								<-- here
	list_for_each_entry(section_node, &sections, list)
		...
}


> 
> > 
> >> +	list_for_each_entry(section_node, &sections, list)
> >> +		if (!strcmp(section_node->name, section_name))
> >> +			return section_node;
> >> +
> >> +	return NULL;
> >> +}
> >> +
> >> +static struct config_element *find_config_element(const char *subkey
> >> +						  , struct config_section *section_node)

And this is not how we put comma, please change it to

static struct config_element *find_config_element(const char *subkey,
						  struct config_section *section_node)

Ditto for others..

Thanks,
Namhyung