From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YjpwI-0005Y0-8L for mharc-grub-devel@gnu.org; Sun, 19 Apr 2015 10:11:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YjpwF-0005XU-15 for grub-devel@gnu.org; Sun, 19 Apr 2015 10:11:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yjpw9-0003i3-VN for grub-devel@gnu.org; Sun, 19 Apr 2015 10:11:10 -0400 Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]:36563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yjpw9-0003ht-Mu for grub-devel@gnu.org; Sun, 19 Apr 2015 10:11:05 -0400 Received: by lbbqq2 with SMTP id qq2so113073635lbb.3 for ; Sun, 19 Apr 2015 07:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=OOjT2ia0c7KuCqZZU4tbheeBcLwlDrGBvoyUoZMKbzE=; b=xWALmpWuH3BhMe8K9w2zeWRX3pF7W/jrea8kH0aznqCMSExzrPfrBXnHB+K3YzAD12 4uXppsw5yhF0/Ri0+sQda66i9Id1kAb28p0sGjCEm62tIiM1O44X36rhcWOrAs4smqJY 8fTxHpzGwyPw+4a09sxnn0aHvohq9fuFakTUToWpx56oe3yCGnr1Y97+n20jsU45eL/3 07OvTRD6wKlRqaGRohPqAinQ5n2qeDSQCnlTpYnFwz2m3cmHB5PKBMewSJwcfUmkx/Y7 46lJ2NO1+tzcjwNtE0jdbcQn1CFxbGPMLzMHhpi9GIpupYgtMcWe485y19l/DpGU0BYp aZ6Q== X-Received: by 10.152.10.180 with SMTP id j20mr12174805lab.54.1429452664959; Sun, 19 Apr 2015 07:11:04 -0700 (PDT) Received: from opensuse.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id ml10sm3694490lbc.29.2015.04.19.07.11.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Apr 2015 07:11:04 -0700 (PDT) Date: Sun, 19 Apr 2015 17:11:02 +0300 From: Andrei Borzenkov To: Toomas Soome Subject: Re: [PATCH 3/5] zfs com.delphix:hole_birth feature support Message-ID: <20150419171102.6433b4b4@opensuse.site> In-Reply-To: <35A91AA4-73E2-46D7-8E86-3323C3299DD1@me.com> References: <35A91AA4-73E2-46D7-8E86-3323C3299DD1@me.com> X-Mailer: Claws Mail 3.11.0 (GTK+ 2.24.27; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::235 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2015 14:11:12 -0000 =D0=92 Thu, 16 Apr 2015 08:22:08 +0300 Toomas Soome =D0=BF=D0=B8=D1=88=D0=B5=D1=82: This really needs better explanation. Otherwise this looks like either old code was broken to start with and it is a bug fix or new code needs some conditionals on new feature. >=20 > --- > grub-core/fs/zfs/zfs.c | 6 ++++-- > include/grub/zfs/spa.h | 4 +++- > 2 files changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/grub-core/fs/zfs/zfs.c b/grub-core/fs/zfs/zfs.c > index 2689986..a731c3d 100644 > --- a/grub-core/fs/zfs/zfs.c > +++ b/grub-core/fs/zfs/zfs.c > @@ -280,7 +280,9 @@ grub_crypto_cipher_handle_t (*grub_zfs_load_key) (con= st struct grub_zfs_key *key > */ > #define MAX_SUPPORTED_FEATURE_STRLEN 50 > static const char *spa_feature_names[] =3D { > - "org.illumos:lz4_compress",NULL > + "org.illumos:lz4_compress", > + "com.delphix:hole_birth", > + NULL > }; > =20 > static int > @@ -1751,7 +1753,7 @@ zio_read_gang (blkptr_t * bp, grub_zfs_endian_t end= ian, dva_t * dva, void *buf, > =20 > for (i =3D 0; i < SPA_GBH_NBLKPTRS; i++) > { > - if (zio_gb->zg_blkptr[i].blk_birth =3D=3D 0) > + if (BP_IS_HOLE(&zio_gb->zg_blkptr[i])) > continue; > =20 > err =3D zio_read_data (&zio_gb->zg_blkptr[i], endian, buf, data); > diff --git a/include/grub/zfs/spa.h b/include/grub/zfs/spa.h > index 7edb8ab..df43b6b 100644 > --- a/include/grub/zfs/spa.h > +++ b/include/grub/zfs/spa.h > @@ -279,7 +279,9 @@ typedef struct blkptr { > =20 > #define BP_IDENTITY(bp) (&(bp)->blk_dva[0]) > #define BP_IS_GANG(bp) DVA_GET_GANG(BP_IDENTITY(bp)) > -#define BP_IS_HOLE(bp) ((bp)->blk_birth =3D=3D 0) > +#define DVA_IS_EMPTY(dva) ((dva)->dva_word[0] =3D=3D 0ULL && \ > + (dva)->dva_word[1] =3D=3D 0ULL) > +#define BP_IS_HOLE(bp) DVA_IS_EMPTY(BP_IDENTITY(bp)) > =20 > /* BP_IS_RAIDZ(bp) assumes no block compression */ > #define BP_IS_RAIDZ(bp) (DVA_GET_ASIZE(&(bp)->blk_dva[0]) > \