From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yorick Rommers <yorick-rommers@hotmail.com>
Cc: joe@perches.com, devel@driverdev.osuosl.org,
lidza.louina@gmail.com, driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH] Staging: dgnc: Using temporary value for repeated dereferences.
Date: Mon, 20 Apr 2015 11:27:46 +0300 [thread overview]
Message-ID: <20150420082745.GV10964@mwanda> (raw)
In-Reply-To: <BLU436-SMTP4562A300449C744FA58029EE10@phx.gbl>
On Sun, Apr 19, 2015 at 11:58:53PM +0200, Yorick Rommers wrote:
> Hello Joe,
>
> Thank you once again for the feedback.
> I've changed my patch accordingly, see below.
>
> --------------------------------------
The patch is nice except for this chunk. And also you should be putting
version numbers in the patch description:
[PATCH v4] Staging: dgnc: Using temporary variable to save space
>
> A patch for a line being too long (>80) in dgnc_mgmt.c,
> fixed by making a temporary value for dgnc_Board[brd],
> replacing all instanced of dgnc_Board[brd] with temporary value,
> and removing unnecessary typecasts.
>
> Signed-off-by: Yorick Rommers <yorick-rommers@hotmail.com>
> ---
And put a note under the cut off here.
---
v4: Removed email to Joe Perches from the patch description
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-20 8:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 19:18 [PATCH] Staging: dgnc: fixed code style issue Yorick Rommers
2015-04-19 20:34 ` Joe Perches
2015-04-19 21:58 ` [PATCH] Staging: dgnc: Using temporary value for repeated dereferences Yorick Rommers
2015-04-20 0:54 ` Joe Perches
2015-04-20 7:33 ` [PATCH] Staging: dgnc: Using a " Yorick Rommers
2015-05-03 18:50 ` Greg KH
2015-04-20 8:33 ` [PATCH] Staging: dgnc: Using " Dan Carpenter
2015-04-20 10:42 ` gcc doesn't warn about uninitialized variable use in switch/case with -O (was: Re: [PATCH] Staging: dgnc: Using temporary value for repeated dereferences) Joe Perches
2015-04-20 12:28 ` Joe Perches
2015-04-20 8:27 ` Dan Carpenter [this message]
2015-04-20 8:13 ` [PATCH] Staging: dgnc: fixed code style issue Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420082745.GV10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yorick-rommers@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.