From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [alsa-devel] [PATCH 1/2] extcon: arizona: Add support for select accessory detect mode when headphone detection" Date: Mon, 20 Apr 2015 09:29:18 +0100 Message-ID: <20150420082918.GF3480@opensource.wolfsonmicro.com> References: <1429259579-16563-1-git-send-email-ideal.song@samsung.com> <1429259579-16563-2-git-send-email-ideal.song@samsung.com> <20150417090047.GC3480@opensource.wolfsonmicro.com> <20150420104514.5820fa93@songinha-Samsung-DeskTop-System> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150420104514.5820fa93@songinha-Samsung-DeskTop-System> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Inha Song Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, patches-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, cw00.choi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: alsa-devel@alsa-project.org On Mon, Apr 20, 2015 at 10:45:14AM +0900, Inha Song wrote: > Hi, > > Thanks for your comments, > > > On Fri, 17 Apr 2015 10:00:47 +0100 > Charles Keepax wrote: > > > On Fri, Apr 17, 2015 at 05:32:58PM +0900, Inha Song wrote: > > > This patch add support for select accessory detect mode to HPDETL or HPDETR. > > > Arizona provides a headphone detection circuit on the HPDETL and HPDETR pins > > > to measure the impedance of an external load connected to the headphone. > > > > > > Depending on board design, headphone detect pins can change to HPDETR or HPDETL. > > > > > > Signed-off-by: Inha Song > > > --- > > > > > + > > > info->micvdd = devm_regulator_get(&pdev->dev, "MICVDD"); > > > if (IS_ERR(info->micvdd)) { > > > ret = PTR_ERR(info->micvdd); > > > @@ -1338,6 +1359,11 @@ static int arizona_extcon_probe(struct platform_device *pdev) > > > > > > arizona_extcon_set_mode(info, 0); > > > > > > + if (arizona->pdata.hpdet_channel) > > > + info->hpdet_channel = ARIZONA_ACCDET_MODE_HPR; > > > + else > > > + info->hpdet_channel = ARIZONA_ACCDET_MODE_HPL; > > > + > > > > Just move the two defines in include/dt-bindings/mfd/arizona.h > > and have the pdata get set directly to one of the values. > > Ok, I agree. But I have a question. > Should I also move ACCDET_MODE_MIC define to dt-bindings header? > Yeah I think move that over too, there is a reasonable chance it will be need as part of the binding at some point in the future. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754788AbbDTI3Z (ORCPT ); Mon, 20 Apr 2015 04:29:25 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:49979 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752641AbbDTI3V (ORCPT ); Mon, 20 Apr 2015 04:29:21 -0400 Date: Mon, 20 Apr 2015 09:29:18 +0100 From: Charles Keepax To: Inha Song Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, rf@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, cw00.choi@samsung.com, broonie@kernel.org, lee.jones@linaro.org Subject: Re: [alsa-devel] [PATCH 1/2] extcon: arizona: Add support for select accessory detect mode when headphone detection" Message-ID: <20150420082918.GF3480@opensource.wolfsonmicro.com> References: <1429259579-16563-1-git-send-email-ideal.song@samsung.com> <1429259579-16563-2-git-send-email-ideal.song@samsung.com> <20150417090047.GC3480@opensource.wolfsonmicro.com> <20150420104514.5820fa93@songinha-Samsung-DeskTop-System> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150420104514.5820fa93@songinha-Samsung-DeskTop-System> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2015 at 10:45:14AM +0900, Inha Song wrote: > Hi, > > Thanks for your comments, > > > On Fri, 17 Apr 2015 10:00:47 +0100 > Charles Keepax wrote: > > > On Fri, Apr 17, 2015 at 05:32:58PM +0900, Inha Song wrote: > > > This patch add support for select accessory detect mode to HPDETL or HPDETR. > > > Arizona provides a headphone detection circuit on the HPDETL and HPDETR pins > > > to measure the impedance of an external load connected to the headphone. > > > > > > Depending on board design, headphone detect pins can change to HPDETR or HPDETL. > > > > > > Signed-off-by: Inha Song > > > --- > > > > > + > > > info->micvdd = devm_regulator_get(&pdev->dev, "MICVDD"); > > > if (IS_ERR(info->micvdd)) { > > > ret = PTR_ERR(info->micvdd); > > > @@ -1338,6 +1359,11 @@ static int arizona_extcon_probe(struct platform_device *pdev) > > > > > > arizona_extcon_set_mode(info, 0); > > > > > > + if (arizona->pdata.hpdet_channel) > > > + info->hpdet_channel = ARIZONA_ACCDET_MODE_HPR; > > > + else > > > + info->hpdet_channel = ARIZONA_ACCDET_MODE_HPL; > > > + > > > > Just move the two defines in include/dt-bindings/mfd/arizona.h > > and have the pdata get set directly to one of the values. > > Ok, I agree. But I have a question. > Should I also move ACCDET_MODE_MIC define to dt-bindings header? > Yeah I think move that over too, there is a reasonable chance it will be need as part of the binding at some point in the future. Thanks, Charles