From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] libxl: initialize vfb defbools in
 libxlMakeVfb
Date: Mon, 20 Apr 2015 12:20:09 +0200
Message-ID: <20150420102009.GA16540@aepfle.de>
References: <1429291171-23640-1-git-send-email-olaf@aepfle.de>
	<553161CA.2090906@suse.com> <1429519143.25195.363.camel@citrix.com>
	<20150420093239.GA14169@aepfle.de>
	<1429523010.25195.397.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1429523010.25195.397.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: libvir-list@redhat.com, Jim Fehlig <jfehlig@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Mon, Apr 20, Ian Campbell wrote:

> If what you said were true then an assert would be a rather harsh
> overreaction to an application coding error.

Currently both libxl and libvirt are coded that way. Since the sdl code
path in libvirt was never executed the crash in libxlMakeVfbList was not
noticed.

So you are saying that an external user of libxl_device_vfb_init has to
call yet another function to initialize all defbool to give them either
true of false? Or should libxl_device_vfb_init call
libxl__device_vfb_setdefault directly?

Olaf