From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: kvm <kvm@vger.kernel.org>, Joel Schopp <joel.schopp@amd.com>
Subject: Re: [RFC][PATCH] KVM: SVM: Sync g_pat with guest-written PAT value
Date: Mon, 20 Apr 2015 18:14:02 +0200 [thread overview]
Message-ID: <20150420161401.GB26491@potion.brq.redhat.com> (raw)
In-Reply-To: <552B6923.3020602@siemens.com>
2015-04-13 08:58+0200, Jan Kiszka:
> When hardware supports the g_pat VMCB field, we can use it for emulating
> the PAT configuration that the guest configures by writing to the
> corresponding MSR.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> RFC because it is only compile-tested.
>
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> @@ -3245,6 +3245,15 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr)
> case MSR_VM_IGNNE:
> vcpu_unimpl(vcpu, "unimplemented wrmsr: 0x%x data 0x%llx\n", ecx, data);
> break;
> + case MSR_IA32_CR_PAT:
> + if (npt_enabled) {
> + if (!kvm_mtrr_valid(vcpu, MSR_IA32_CR_PAT, data))
> + return 1;
> + svm->vmcb->save.g_pat = data;
> + vcpu->arch.pat = data;
Disregarding my Reviewed-by, the code is missing:
mark_dirty(svm->vmcb, VMCB_NPT);
Also,
Tested-by: Radim Krčmář <rkrcmar@redhat.com>
next prev parent reply other threads:[~2015-04-20 16:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 5:16 KVM: How does is PAT emulation supposed to work? Jan Kiszka
2015-04-13 6:58 ` [RFC][PATCH] KVM: SVM: Sync g_pat with guest-written PAT value Jan Kiszka
2015-04-17 16:59 ` Radim Krčmář
2015-04-20 16:14 ` Radim Krčmář [this message]
2015-04-20 17:16 ` Radim Krčmář
2015-04-20 17:21 ` Jan Kiszka
2015-04-20 17:33 ` Radim Krčmář
2015-04-20 17:37 ` Jan Kiszka
2015-04-20 17:45 ` Jan Kiszka
2015-04-20 18:33 ` Radim Krčmář
2015-04-20 18:41 ` Jan Kiszka
2015-04-21 12:10 ` Radim Krčmář
2015-04-21 12:11 ` Paolo Bonzini
2015-04-20 17:22 ` Radim Krčmář
2015-04-20 17:25 ` [PATCH v2] " Jan Kiszka
2015-04-20 17:35 ` Radim Krčmář
2015-04-21 11:09 ` Paolo Bonzini
2015-04-21 11:25 ` Jan Kiszka
2015-04-21 11:32 ` Paolo Bonzini
2015-04-21 11:56 ` Jan Kiszka
2015-04-21 12:12 ` Paolo Bonzini
2015-04-21 12:21 ` Radim Krčmář
2015-05-24 15:28 ` Jan Kiszka
2016-02-09 19:25 ` Jan Kiszka
2015-04-17 16:43 ` KVM: How does is PAT emulation supposed to work? Radim Krčmář
2015-04-17 17:12 ` Jan Kiszka
2015-04-17 20:28 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420161401.GB26491@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=joel.schopp@amd.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.