From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH 16/24] link_path_walk: kill the recursion Date: Mon, 20 Apr 2015 22:59:23 +0100 Message-ID: <20150420215923.GQ889@ZenIV.linux.org.uk> References: <20150420181222.GK889@ZenIV.linux.org.uk> <1429553588-24764-16-git-send-email-viro@ZenIV.linux.org.uk> <20150420213247.GN889@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Neil Brown , Linux Kernel Mailing List , linux-fsdevel To: Linus Torvalds Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Apr 20, 2015 at 02:42:56PM -0700, Linus Torvalds wrote: > On Mon, Apr 20, 2015 at 2:41 PM, Linus Torvalds > wrote: > > > > And no, we will *never* lift the recursion limit. Not for 1kB, not for > > 1MB. Never. > > Just to clarify: that's for the "remove restrictions completely". > Upping it to 32 or 40 would be fine. But not with allocations on the > stack. Yep. There are two restrictions - one on the total amount of symlinks encountered (40), and another on the depth of nesting (8). The latter is due to recursion issues, and with dynamic nd->stack it goes away. The former, of course, stays, for the reasons you've mentioned - it has nothing to do with the depth of recursion.