From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] python-pyqt: fix compile on x86
Date: Mon, 20 Apr 2015 23:07:36 +0200 [thread overview]
Message-ID: <20150420230736.489bfd99@free-electrons.com> (raw)
In-Reply-To: <1429543759-32207-1-git-send-email-gwenj@trabucayre.com>
Dear Gwenhael Goavec-Merou,
On Mon, 20 Apr 2015 17:29:17 +0200, Gwenhael Goavec-Merou wrote:
> From: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
>
> fix :
> http://autobuild.buildroot.net/results/e2a/e2ab7e2e61aaa5758a3a572ae25a047e802fdcc0/
>
> According to configure-ng.py, PyQt_qreal_double must be disabled only for ARM
> target.
The situation seems unfortunately to be a bit more complicated. From
the configure-ng.py code:
#if defined(QT_NO_FPU) || defined(QT_ARCH_ARM) || defined(QT_ARCH_WINDOWSCE) || defined(QT_ARCH_SYMBIAN) || defined(QT_ARCH_VXWORKS)
out << "PyQt_qreal_double\\n";
#endif
We indeed don't care about Windows CE, Symbian or VxWorks. QT_ARCH_ARM
is handled by your patch. But not QT_NO_FPU. QT_NO_FPU is defined by Qt
in the following situation:
#if defined(QT_ARCH_ARM) || defined(QT_ARCH_ARMV6) || defined(QT_ARCH_AVR32) || (defined(QT_ARCH_MIPS) && (defined(Q_WS_QWS) || defined(Q_WS_QPA) || defined(Q_OS_WINCE))) || defined(QT_ARCH_SH) || defined(QT_ARCH_SH4A)
#define QT_NO_FPU
#endif
So it's not only ARM, but also SH, SH4A and MIPS in QWS apparently.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-04-20 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 15:29 [Buildroot] [PATCH 1/3] python-pyqt: fix compile on x86 Gwenhael Goavec-Merou
2015-04-20 15:29 ` [Buildroot] [PATCH 2/3] python-pyqt: fix install Gwenhael Goavec-Merou
2015-04-20 15:37 ` Thomas Petazzoni
2015-04-20 15:45 ` gwenhael.goavec
2015-04-20 21:02 ` Arnout Vandecappelle
2015-04-20 15:29 ` [Buildroot] [PATCH 3/3] qt: fix webkit dependencies Gwenhael Goavec-Merou
2015-04-20 21:07 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420230736.489bfd99@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.