All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
	David Ahern <dsahern@gmail.com>,
	Taeung Song <treeze.taeung@gmail.com>
Subject: Re: [PATCH v2] perf tools: Document --children option in more detail
Date: Tue, 21 Apr 2015 09:26:10 +0200	[thread overview]
Message-ID: <20150421072610.GB22291@gmail.com> (raw)
In-Reply-To: <20150421070108.GE1905@sejong>


* Namhyung Kim <namhyung@kernel.org> wrote:

> Hi Ingo,
> 
> On Mon, Apr 20, 2015 at 08:04:11PM +0200, Ingo Molnar wrote:
> > 
> > * Namhyung Kim <namhyung@kernel.org> wrote:
> > 
> > > As the --children option changes the output of perf report (and perf
> > > top) it sometimes confuses users.  Add more words and examples to help
> > > understanding of the option's behavior - and how to disable it ;-).
> > 
> > Nice! :-)
> 
> Thanks! :)
> 
> > 
> > > +++ b/tools/perf/Documentation/overhead.txt
> > 
> > As some people might stumble upon this the old fashioned way, by 
> > looking around in 'Documentation/', I'm wondering how this file name 
> > will tell the reader that this is about call chains? (which isn't the 
> > default recording mode) Maybe name it more explicitly, like 
> > callchain-overhead.txt?
> 
> OK.  But I'd rather name it 'overhead-calculation.txt' to align with
> the section name.  And 'callchain-overhead' makes me thinking about
> the overhead of processing callchains at record or report time.

Sure!

> > s/perfconfig/.perfconfig
> > 
> > ?
> 
> It seems we can have a system-wide /etc/perfconfig too.  How about
> 'the perf config file' instead?

Yeah.

Thanks,

	Ingo

      reply	other threads:[~2015-04-21  7:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 12:42 [PATCH v2] perf tools: Document --children option in more detail Namhyung Kim
2015-04-20 18:04 ` Ingo Molnar
2015-04-21  7:01   ` Namhyung Kim
2015-04-21  7:26     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150421072610.GB22291@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=treeze.taeung@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.