From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: aha1542: rework locking
Date: Tue, 21 Apr 2015 14:41:55 +0300 [thread overview]
Message-ID: <20150421114155.GG16501@mwanda> (raw)
In-Reply-To: <201504211239.40423.linux@rainbow-software.org>
On Tue, Apr 21, 2015 at 12:39:40PM +0200, Ondrej Zary wrote:
> Thanks, I missed that as it was already wrong before (since at least when
> DEF_SCSI_QCMD was introduced). And it worked despite that.
If you turn on CONFIG_DEBUG_ATOMIC_SLEEP=y it will generate a warning
splat. Otherwise you probably have to get very unlucky for this to
deadlock.
>
> Should I just change that to GFP_ATOMIC?
The other option is to do the allocation before taking the lock. That
looks do-able. You are the expert here by virtue of you touched to code
last. So you get to decide. :)
regards,
dan carpenter
prev parent reply other threads:[~2015-04-21 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 9:26 aha1542: rework locking Dan Carpenter
2015-04-21 10:39 ` Ondrej Zary
2015-04-21 11:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421114155.GG16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.