All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Gal Hammer <ghammer@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope.
Date: Tue, 21 Apr 2015 14:53:54 +0200	[thread overview]
Message-ID: <20150421125354.GA7727@redhat.com> (raw)
In-Reply-To: <CAFEAcA98SUNLKOg0xqam03nLAs-CnOpx_6y7PAybKppRbKgKAA@mail.gmail.com>

On Tue, Apr 21, 2015 at 12:33:36PM +0100, Peter Maydell wrote:
> On 21 April 2015 at 11:09, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Tue, Apr 21, 2015 at 11:26:12AM +0300, Gal Hammer wrote:
> >> A predefined scope in the ACPI specs is precede with a backslash.
> >>
> >> Signed-off-by: Gal Hammer <ghammer@redhat.com>
> >
> > s/precede/preceded/
> >
> > This is correct, but do we need this in 2.3?
> > I'm split on this. Thoughts?
> > If yes, commit log needs better explanation on what
> > the effect on guests is.
> 
> Unless the effect is absolutely catastrophic you've missed
> the boat for 2.3, and should settle for 2.4 + cc:stable.
> 
> thanks
> -- PMM

I rechecked a bunch of guests and they all seem to behave identically
with and without the patch.
2.4 it is.

Thanks.

-- 
MST

  reply	other threads:[~2015-04-21 12:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21  8:26 [Qemu-devel] [PATCH] acpi: add a missing backslash to the \_SB scope Gal Hammer
2015-04-21  9:38 ` Igor Mammedov
2015-04-21 10:09 ` Michael S. Tsirkin
2015-04-21 11:33   ` Peter Maydell
2015-04-21 12:53     ` Michael S. Tsirkin [this message]
2015-04-22  6:13       ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150421125354.GA7727@redhat.com \
    --to=mst@redhat.com \
    --cc=ghammer@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.