From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] pkg-generic: prepend downloaded patches w/ package
Date: Tue, 21 Apr 2015 16:39:24 +0200 [thread overview]
Message-ID: <20150421163924.0387bdb4@free-electrons.com> (raw)
In-Reply-To: <CA+-urNTcHpvcg1Y7rFCVWAUsE2RjEO0QhBvFca2gAcyLWm8URw@mail.gmail.com>
Dear Frank Hunleth,
On Tue, 21 Apr 2015 10:20:46 -0400, Frank Hunleth wrote:
> > There are obviously some implications (organization of files in
> > BR2_PRIMARY_SITE and on sources.buildroot.net), but isn't this the
> > easiest solution, after all? Or am I missing something?
>
> Yes. This would be another route barring the new issue that I just ran
> into with _PATCH.
>
> The issue occurs when Intel updates their kernel or u-boot patches
> without updating which kernel or u-boot that they use. The remote file
> name of the patches is still the same (upstream_to_edison.patch). The
> kernel or u-boot package versions are also still the same. So unless I
> append some additional versioning information to the filename stored
> in $(DL_DIR), the new patch won't be downloaded.
Indeed my proposal would not solve this problem.
Alternate options:
1/ Fix upstream. Talk to the Intel people doing this sort of awful
mess to fix their workflow and rename patches with appropriate
versions.
2/ Have a way of passing the expected hash for custom patches to
download, so that the Buildroot download infra can notice that the
hashes are not correct anymore, and will redownload.
Maybe:
BR2_TARGET_UBOOT_PATCH="http://intel.com/stupid.patch{md5:2394fc9ba9094f8e6d0a59490a1fa65e}"
?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-04-21 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-19 16:57 [Buildroot] [PATCH 1/2] pkg-download: add optional destination filename Frank Hunleth
2015-04-19 16:57 ` [Buildroot] [PATCH 2/2] pkg-generic: prepend downloaded patches w/ package Frank Hunleth
2015-04-20 22:09 ` Arnout Vandecappelle
2015-04-21 13:03 ` Frank Hunleth
2015-04-21 13:30 ` Thomas Petazzoni
2015-04-21 14:20 ` Frank Hunleth
2015-04-21 14:39 ` Thomas Petazzoni [this message]
2015-04-21 16:03 ` Frank Hunleth
2015-04-20 21:50 ` [Buildroot] [PATCH 1/2] pkg-download: add optional destination filename Arnout Vandecappelle
2015-07-14 22:39 ` Thomas Petazzoni
2015-07-15 14:07 ` Frank Hunleth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421163924.0387bdb4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.