From mboxrd@z Thu Jan 1 00:00:00 1970 From: jgunthorpe@obsidianresearch.com (Jason Gunthorpe) Date: Tue, 21 Apr 2015 14:57:16 -0600 Subject: [Cocci] [PATCH v3 2/3] IB/qib: use arch_phys_wc_add() In-Reply-To: <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com> References: <1429648676-17755-1-git-send-email-mcgrof@do-not-panic.com> <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com> Message-ID: <20150421205716.GA474@obsidianresearch.com> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already makes use of ioremap_wc() on PIO buffers, > so convert it to use arch_phys_wc_add(). This is probably OK, but I think you should also remove the qib_wc_pat module parameter. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Tue, 21 Apr 2015 20:57:16 +0000 Subject: Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add() Message-Id: <20150421205716.GA474@obsidianresearch.com> List-Id: References: <1429648676-17755-1-git-send-email-mcgrof@do-not-panic.com> <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com> In-Reply-To: <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already makes use of ioremap_wc() on PIO buffers, > so convert it to use arch_phys_wc_add(). This is probably OK, but I think you should also remove the qib_wc_pat module parameter. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add() Date: Tue, 21 Apr 2015 14:57:16 -0600 Message-ID: <20150421205716.GA474@obsidianresearch.com> References: <1429648676-17755-1-git-send-email-mcgrof@do-not-panic.com> <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1429648676-17755-3-git-send-email-mcgrof-3uybbJdB1yH774rrrx3eTA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Luis R. Rodriguez" Cc: infinipath-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org, mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, cocci-/FJkirnvOdkvYVN+rsErww@public.gmane.org, "Luis R. Rodriguez" , Toshi Kani , Rickard Strandqvist , Mike Marciniszyn , Roland Dreier , Dennis Dalessandro , Suresh Siddha , Ingo Molnar , Thomas Gleixner , Juergen Gross , Daniel Vetter , Dave Airlie , Bjorn Helgaas , Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Dave Hansen , Arn List-Id: linux-rdma@vger.kernel.org On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already makes use of ioremap_wc() on PIO buffers, > so convert it to use arch_phys_wc_add(). This is probably OK, but I think you should also remove the qib_wc_pat module parameter. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964896AbbDUU6V (ORCPT ); Tue, 21 Apr 2015 16:58:21 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:35653 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932096AbbDUU6R (ORCPT ); Tue, 21 Apr 2015 16:58:17 -0400 Date: Tue, 21 Apr 2015 14:57:16 -0600 From: Jason Gunthorpe To: "Luis R. Rodriguez" Cc: infinipath@intel.com, roland@kernel.org, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, luto@amacapital.net, mst@redhat.com, cocci@systeme.lip6.fr, "Luis R. Rodriguez" , Toshi Kani , Rickard Strandqvist , Mike Marciniszyn , Roland Dreier , Dennis Dalessandro , Suresh Siddha , Ingo Molnar , Thomas Gleixner , Juergen Gross , Daniel Vetter , Dave Airlie , Bjorn Helgaas , Antonino Daplas , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Dave Hansen , Arnd Bergmann , Stefan Bader , konrad.wilk@oracle.com, ville.syrjala@linux.intel.com, david.vrabel@citrix.com, jbeulich@suse.com, Roger Pau =?iso-8859-1?Q?Monn=E9?= , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com Subject: Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add() Message-ID: <20150421205716.GA474@obsidianresearch.com> References: <1429648676-17755-1-git-send-email-mcgrof@do-not-panic.com> <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429648676-17755-3-git-send-email-mcgrof@do-not-panic.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.183 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > This driver already makes use of ioremap_wc() on PIO buffers, > so convert it to use arch_phys_wc_add(). This is probably OK, but I think you should also remove the qib_wc_pat module parameter. Jason