Re: [PATCH v2] i2c: Mark adapter devices with pm_runtime_no_callbacks

[Wolfram Sang <wsa@the-dreams.de>]

[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]

On Thu, Apr 16, 2015 at 02:28:02PM +0200, Beata Michalska wrote:
> On 04/16/2015 02:05 PM, Charles Keepax wrote:
> > Commit 523c5b89640e ("i2c: Remove support for legacy PM") removed the PM
> > ops from the bus type, which causes the pm operations on the s3c2410
> > adapter device to fail (-ENOSUPP in rpm_callback). The adapter device
> > doesn't get bound to a driver and as such can't have its own pm_runtime
> > callbacks. Previously this was fine as the bus callbacks would have been
> > used, but now this can cause devices which use PM runtime and are
> > attached over I2C to fail to resume.
> >
> > This commit fixes this issue by marking all adapter devices with
> > pm_runtime_no_callbacks, since they can't have any.
> >
> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> 
> Thereis at least one more casewhen an I2C device fails to resume due
> to bus callbacks being dropped(like fimc-is-i2c driver for exynos4-is,
> the same scenario),  so I'm glad to see  it's being handled in on place
> -it saves the trouble.

Thanks for the confirmation! If you could also add a formal 'Acked-by'
next time, this would help me because patchwork collects them for me
automatically.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]