From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757389AbbDVNnM (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Apr 2015 09:43:12 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:43768 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932185AbbDVNnK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Apr 2015 09:43:10 -0400
Date: Wed, 22 Apr 2015 14:43:06 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-kernel@vger.kernel.org, j@w1.fi,
        Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] fs/9p: fix readdir()
Message-ID: <20150422134306.GV889@ZenIV.linux.org.uk>
References: <1429696514-14779-1-git-send-email-johannes@sipsolutions.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1429696514-14779-1-git-send-email-johannes@sipsolutions.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 22, 2015 at 11:55:14AM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
> 
> Al Viro's IOV changes broke 9p readdir() because the new code
> didn't abort the read when it returned nothing. The original
> code checked if the combined error/length was <= 0 but in the
> new code that accidentally got changed to just an error check.
> 
> Add back the return from the function when nothing is read.

Nice catch...  FWIW, this hadn't been caught since it doesn't trigger
on 9P.L tests.  Applied, and testing setup fixed.