Re: [LTP] [PATCH v4 1/2] syscalls/utimensat01: Use test.sh library for test case

[Cyril Hrubis <chrubis@suse.cz>]

>  echo "Total tests: $test_num; passed: $passed_cnt; failed: $failed_cnt"
>  if test $failed_cnt -gt 0; then
>      echo "Failed tests: $failed_list"
> -    exit -1
> +    tst_resm TFAIL "test failed"
>  fi
> 
> -exit
> +tst_resm TPASS "test pass"

The tst_resm TPASS should be in the else part of the if above, otherwise
the test will print both failure and success in case that failed_cnt is
greater than zero.

And changing the check_result() to call tst_resm TFAIL/TPASS directly
would be even better. In that case this part will call only tst_exit as
the pass/fail status will be saved by the test library.

> +tst_exit
> -- 1.6.0.2

-- 
Cyril Hrubis
chrubis@suse.cz

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list