Re: [PATCH 2/2] visor: Match I330 phone more precisely

[Johan Hovold <johan@kernel.org>]

On Wed, Apr 22, 2015 at 02:35:09PM +0200, Jason A. Donenfeld wrote:
> Samsung has just released a portable USB3 SSD, coming in a very small
> and nice form factor. It's USB ID is 04e8:8001, which unfortunately is
> already used by the Palm Visor driver for the Samsung I330 phone cradle.
> Having pl2303 or visor pick up this device ID results in conflicts with
> the usb-storage driver, which handles the newly released portable USB3
> SSD.
> 
> To work around this conflict, I've dug up a mailing list post [1] from a
> long time ago, in which a user posts the full USB descriptor
> information. The most specific value in this appears to be the interface
> class, which has value 255 (0xff). Since usb-storage requires an
> interface class of 0x8, I believe it's correct to disambiguate the two
> devices by matching on 0xff inside visor.
> 
> [1] http://permalink.gmane.org/gmane.linux.usb.user/4264
> 
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>

Both patches look good, but next time remember to include a patch
revision in the subject of all patches in a series (this would be
[PATCH v3]). Please use a "USB: " prefix as well.

I'll fix it up before applying this time.

Thanks,
Johan