From mboxrd@z Thu Jan 1 00:00:00 1970 From: "ira.weiny" Subject: Re: [PATCH v5 01/27] IB/Verbs: Implement new callback query_transport() Date: Wed, 22 Apr 2015 12:22:34 -0400 Message-ID: <20150422162233.GA1494@phlsvsds.ph.intel.com> References: <5534B8C9.506@profitbricks.com> <5534B981.1030302@profitbricks.com> <1429714975.45956.113.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Devesh Sharma Cc: Doug Ledford , Michael Wang , Roland Dreier , Sean Hefty , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org" , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran , Tom Talpey , Jason Gunthorpe List-Id: linux-rdma@vger.kernel.org On Wed, Apr 22, 2015 at 03:21:43PM +0000, Devesh Sharma wrote: > > -----Original Message----- > > From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma- > > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Doug Ledford > > Sent: Wednesday, April 22, 2015 8:33 PM > > To: Michael Wang > > Cc: Roland Dreier; Sean Hefty; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux- > > kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org; Tom Tucker; Steve Wise; > > Hoang-Nam Nguyen; Christoph Raisch; Mike Marciniszyn; Eli Cohen; Faisal > > Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran; Ira Weiny; Tom Talpey; Jason > > Gunthorpe > > Subject: Re: [PATCH v5 01/27] IB/Verbs: Implement new callback > > query_transport() > > > > On Mon, 2015-04-20 at 10:32 +0200, Michael Wang wrote: > > > Add new callback query_transport() and implement for each HW. > > > > The more I think about it, the more I think we need to eliminate this patch > > entirely. > > > > The problem here is that, if we follow my suggestion, then we are going to > > eliminate the query as an API function and replace the information it gives us > > with a static port attribute bitmap. If we do this patch, then reform this patch > > to my idea later, we introduce a very short lived API/ABI change in the kernel > > module interface that serves absolutely no purpose. Instead, let's do the > > bitmap creation first, update the drivers to properly set the bitmap, then do all > > of the remaining reforms you have here using that bitmap and completely skip > > the > > query_transport() API item that will no longer serve a purpose. > > Any vendor device that registers with IB stack already has capability flags, are you referring to the same as bit maps? > Is it possible to use same as bitmaps you are referring to? I am trying to understand you complete idea. The idea was to use additional bit maps. https://www.mail-archive.com/linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg23765.html Ira -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965616AbbDVQW6 (ORCPT ); Wed, 22 Apr 2015 12:22:58 -0400 Received: from mga11.intel.com ([192.55.52.93]:56812 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964807AbbDVQWw (ORCPT ); Wed, 22 Apr 2015 12:22:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,624,1422950400"; d="scan'208";a="684042779" Date: Wed, 22 Apr 2015 12:22:34 -0400 From: "ira.weiny" To: Devesh Sharma Cc: Doug Ledford , Michael Wang , Roland Dreier , Sean Hefty , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "hal@dev.mellanox.co.il" , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran , Tom Talpey , Jason Gunthorpe Subject: Re: [PATCH v5 01/27] IB/Verbs: Implement new callback query_transport() Message-ID: <20150422162233.GA1494@phlsvsds.ph.intel.com> References: <5534B8C9.506@profitbricks.com> <5534B981.1030302@profitbricks.com> <1429714975.45956.113.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 22, 2015 at 03:21:43PM +0000, Devesh Sharma wrote: > > -----Original Message----- > > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > > owner@vger.kernel.org] On Behalf Of Doug Ledford > > Sent: Wednesday, April 22, 2015 8:33 PM > > To: Michael Wang > > Cc: Roland Dreier; Sean Hefty; linux-rdma@vger.kernel.org; linux- > > kernel@vger.kernel.org; hal@dev.mellanox.co.il; Tom Tucker; Steve Wise; > > Hoang-Nam Nguyen; Christoph Raisch; Mike Marciniszyn; Eli Cohen; Faisal > > Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran; Ira Weiny; Tom Talpey; Jason > > Gunthorpe > > Subject: Re: [PATCH v5 01/27] IB/Verbs: Implement new callback > > query_transport() > > > > On Mon, 2015-04-20 at 10:32 +0200, Michael Wang wrote: > > > Add new callback query_transport() and implement for each HW. > > > > The more I think about it, the more I think we need to eliminate this patch > > entirely. > > > > The problem here is that, if we follow my suggestion, then we are going to > > eliminate the query as an API function and replace the information it gives us > > with a static port attribute bitmap. If we do this patch, then reform this patch > > to my idea later, we introduce a very short lived API/ABI change in the kernel > > module interface that serves absolutely no purpose. Instead, let's do the > > bitmap creation first, update the drivers to properly set the bitmap, then do all > > of the remaining reforms you have here using that bitmap and completely skip > > the > > query_transport() API item that will no longer serve a purpose. > > Any vendor device that registers with IB stack already has capability flags, are you referring to the same as bit maps? > Is it possible to use same as bitmaps you are referring to? I am trying to understand you complete idea. The idea was to use additional bit maps. https://www.mail-archive.com/linux-rdma@vger.kernel.org/msg23765.html Ira