From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932726AbbDVRW5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 22 Apr 2015 13:22:57 -0400
Received: from quartz.orcorp.ca ([184.70.90.242]:32902 "EHLO quartz.orcorp.ca"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753485AbbDVRWz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 22 Apr 2015 13:22:55 -0400
Date: Wed, 22 Apr 2015 11:22:43 -0600
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Simon Wunderlich <sw@simonwunderlich.de>, NeilBrown <neilb@suse.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, Jianyu Zhan <nasa4836@gmail.com>,
        Andrzej Hajda <a.hajda@samsung.com>, tpmdd-devel@lists.sourceforge.net,
        Al Viro <viro@zeniv.linux.org.uk>, Tejun Heo <tj@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>,
        "Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [tpmdd-devel] [PATCH v2] tpm: enable PPI for TPM 2.0
Message-ID: <20150422172243.GE19500@obsidianresearch.com>
References: <1429641062-14421-1-git-send-email-jarkko.sakkinen@linux.intel.com>
 <20150421193338.GA31179@obsidianresearch.com>
 <20150422055755.GC6764@intel.com>
 <20150422163855.GA12013@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150422163855.GA12013@intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.183
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Apr 22, 2015 at 07:38:55PM +0300, Jarkko Sakkinen wrote:
> > > > +EXPORT_SYMBOL_GPL(kernfs_remove_by_name_ns);
> > > 
> > > ??
> > > I don't see this being called
> > 
> > My bad, it is clutter in the patch file. I'll remove it.
> 
> In fact this is needed because the driver uses kernfs_remove_by_name,
> which is an inline function that uses kernfs_remove_by_name_ns
> internally.

Hum, that probably needs a sysfs_ analog - the paired removal
function for sysfs_link_group_to_kobj ?

Jason