From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Simon Wunderlich <sw@simonwunderlich.de>,
NeilBrown <neilb@suse.de>,
linux-kernel@vger.kernel.org, Jianyu Zhan <nasa4836@gmail.com>,
Andrzej Hajda <a.hajda@samsung.com>,
tpmdd-devel@lists.sourceforge.net,
Al Viro <viro@zeniv.linux.org.uk>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Guenter Roeck <linux@roeck-us.net>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [tpmdd-devel] [PATCH v2] tpm: enable PPI for TPM 2.0
Date: Wed, 22 Apr 2015 20:10:24 +0200 [thread overview]
Message-ID: <20150422181024.GA4340@kroah.com> (raw)
In-Reply-To: <20150422172243.GE19500@obsidianresearch.com>
On Wed, Apr 22, 2015 at 11:22:43AM -0600, Jason Gunthorpe wrote:
> On Wed, Apr 22, 2015 at 07:38:55PM +0300, Jarkko Sakkinen wrote:
> > > > > +EXPORT_SYMBOL_GPL(kernfs_remove_by_name_ns);
> > > >
> > > > ??
> > > > I don't see this being called
> > >
> > > My bad, it is clutter in the patch file. I'll remove it.
> >
> > In fact this is needed because the driver uses kernfs_remove_by_name,
> > which is an inline function that uses kernfs_remove_by_name_ns
> > internally.
>
> Hum, that probably needs a sysfs_ analog - the paired removal
> function for sysfs_link_group_to_kobj ?
Be very careful using that sysfs function, you shouldn't be doing that
within a driver subsystem unless you know what you are doing :)
greg k-h
next prev parent reply other threads:[~2015-04-22 18:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 18:30 [PATCH v2] tpm: enable PPI for TPM 2.0 Jarkko Sakkinen
2015-04-21 18:58 ` Guenter Roeck
2015-04-22 5:44 ` Jarkko Sakkinen
2015-04-21 19:33 ` Jason Gunthorpe
2015-04-22 5:57 ` Jarkko Sakkinen
2015-04-22 16:38 ` [tpmdd-devel] " Jarkko Sakkinen
2015-04-22 17:22 ` Jason Gunthorpe
2015-04-22 18:10 ` Greg Kroah-Hartman [this message]
2015-04-23 4:55 ` Jarkko Sakkinen
2015-04-21 19:52 ` Greg Kroah-Hartman
2015-04-22 5:39 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422181024.GA4340@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=a.hajda@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@roeck-us.net \
--cc=nasa4836@gmail.com \
--cc=neilb@suse.de \
--cc=sw@simonwunderlich.de \
--cc=tj@kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.