From: Jeff King <peff@peff.net>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Michael Haggerty <mhagger@alum.mit.edu>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 0/3] Another approach to large transactions
Date: Wed, 22 Apr 2015 16:11:26 -0400 [thread overview]
Message-ID: <20150422201126.GB29282@peff.net> (raw)
In-Reply-To: <CAGZ79kY_1JqKBiAL14me8ktqdQMJ1UuTy1_MgBY4jy5i_qX0uA@mail.gmail.com>
On Wed, Apr 22, 2015 at 12:14:08PM -0700, Stefan Beller wrote:
> > FWIW, we already use a magic value of "25 extra" in open_packed_git_1. I
> > don't know if that means the number has been proven in practice, or if
> > it is simply that nobody actually exercises the pack_max_fds code. I
> > suspect it is the latter, especially since d131b7a (sha1_file.c: Don't
> > retain open fds on small packs, 2011-03-02).
>
> 25 is equally sound as I could not find any hard calculation on that
> number in the
> history or code. I will change it to 25 in the next version of the patch.
FWIW, I think 32 is just fine, too, and the patch doesn't need re-rolled
because of this. I mostly wanted to point out that yes, indeed, we use
this "eh, a few dozen is probably enough" strategy elsewhere. Which
maybe, sort-of validates it. :)
-Peff
next prev parent reply other threads:[~2015-04-22 20:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 23:17 [PATCH 0/3] Another approach to large transactions Stefan Beller
2015-04-16 23:17 ` [PATCH 1/3] refs.c: remove lock_fd from struct ref_lock Stefan Beller
2015-04-16 23:17 ` [PATCH 2/3] Move get_max_fd_limit(void) to git_compat_util.h Stefan Beller
2015-04-16 23:17 ` [PATCH 3/3] refs.c: enable large transactions Stefan Beller
2015-04-17 17:09 ` [PATCH 0/3] Another approach to " Junio C Hamano
2015-04-17 22:12 ` Junio C Hamano
2015-04-17 22:17 ` Stefan Beller
2015-04-17 23:31 ` Stefan Beller
2015-04-20 22:26 ` Stefan Beller
2015-04-20 22:51 ` Junio C Hamano
2015-04-20 23:07 ` Stefan Beller
2015-04-21 0:31 ` Stefan Beller
2015-04-21 0:35 ` [PATCH] refs.c: enable " Stefan Beller
2015-04-21 17:16 ` Junio C Hamano
2015-04-21 17:24 ` Stefan Beller
2015-04-21 18:00 ` Junio C Hamano
2015-04-21 19:06 ` [PATCHv2] " Stefan Beller
2015-04-21 19:56 ` Stefan Beller
2015-04-22 14:11 ` Michael Haggerty
2015-04-22 19:09 ` Stefan Beller
2015-04-22 20:12 ` Michael Haggerty
2015-04-21 17:22 ` [PATCH] " Junio C Hamano
2015-04-21 23:21 ` [PATCH 0/3] Another approach to " Jeff King
2015-04-22 19:14 ` Stefan Beller
2015-04-22 20:11 ` Jeff King [this message]
2015-04-21 17:19 ` Junio C Hamano
2015-04-21 17:31 ` Stefan Beller
2015-04-21 12:37 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422201126.GB29282@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.