All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: don't trigger fsync log force based on inode pin count
Date: Wed, 22 Apr 2015 18:10:47 -0400	[thread overview]
Message-ID: <20150422221047.GB48944@bfoster.bfoster> (raw)
In-Reply-To: <20150422220611.GA8881@infradead.org>

On Wed, Apr 22, 2015 at 03:06:11PM -0700, Christoph Hellwig wrote:
> On Wed, Apr 22, 2015 at 06:02:44PM -0400, Brian Foster wrote:
> > That was what I thought at first but I bumped the extent count a couple
> > times and still couldn't reproduce. I was curious enough to track it
> > down and it is actually the time update again. For whatever reason, I
> > think the crc mechanism is throwing the timing off and just hiding the
> > problem again. E.g., no-op xfs_vn_time_update() and the problem
> > reproduces on v5 as well.
> 
> Actually, its the changecount again.  If MS_I_VERSION is set
> the VFS will always call into ->xfs_vn_time_update.

Ah, I see. Yeah, that explains the time update then...

Brian

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2015-04-22 22:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22 14:37 [PATCH] xfs: don't trigger fsync log force based on inode pin count Brian Foster
2015-04-22 16:15 ` Christoph Hellwig
2015-04-22 17:13   ` Brian Foster
2015-04-22 21:18     ` Dave Chinner
2015-04-22 22:02       ` Brian Foster
2015-04-22 22:06         ` Christoph Hellwig
2015-04-22 22:10           ` Brian Foster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150422221047.GB48944@bfoster.bfoster \
    --to=bfoster@redhat.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.