From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:35729 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933774AbbDWLP6 (ORCPT ); Thu, 23 Apr 2015 07:15:58 -0400 Received: by widdi4 with SMTP id di4so211540438wid.0 for ; Thu, 23 Apr 2015 04:15:57 -0700 (PDT) Date: Thu, 23 Apr 2015 13:15:54 +0200 From: Alexander Aring Subject: Re: First kernel patch - checkpatch for at86rf230.c, false-positives? Message-ID: <20150423111553.GB9284@omega> References: <20150423100918.GA9284@omega> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Christoffer Holmstedt Cc: linux-wpan@vger.kernel.org On Thu, Apr 23, 2015 at 12:25:34PM +0200, Christoffer Holmstedt wrote: ... > > Thank you Alexander for your fast and thorough response, I expected > something like that as other defines did have parantheses. > if you like to send a first patch, maybe to "breaking the ice". Then I see several cleanups there, like I used some magic values for masking the trac status or trx state e.g. "trx_state = buf[1] & 0x1f;". You can introduce some macro for that and replacing it where it used. Or simple sending some patches for whatever you want, I/community will review them. With "breaking the ice", I mean some "testing linux send patch environment" and getting familiar with sending patches. When it is your first time. - Alex