All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Rob Herring <robherring2@gmail.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matt Porter <mporter@konsulko.com>,
	Koen Kooi <koen@dominion.thruhere.net>,
	Guenter Roeck <linux@roeck-us.net>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v2 3/4] of: overlay: Add sysfs attributes
Date: Thu, 23 Apr 2015 15:04:09 +0200	[thread overview]
Message-ID: <20150423130409.GA4437@kroah.com> (raw)
In-Reply-To: <5F0BA9FB-8345-4296-8595-0E4CD1C816AA@konsulko.com>

On Thu, Apr 23, 2015 at 03:59:02PM +0300, Pantelis Antoniou wrote:
> >>>> It’s the same reason that the device tree core is using it.
> >>> 
> >>> It is doing that for "raw" device tree files, not individual attributes,
> >>> right?
> >>> 
> >> 
> >> Each property of a device tree is a binary attribute.
> > 
> > Because they export binary data, right?  I don't have access to a
> > machine that uses device tree at the moment to check this...
> > 
> > Any specific file/function you are referring to?
> > 
> 
> Yes, they export binary data. It works because the device tree nodes
> are raw kobjs.

Great, then the device tree is doing this correctly :)

For text files, use real attribute files, that's the proper way to
handle sysfs from kobjects.

thanks,

greg k-h

  reply	other threads:[~2015-04-23 13:04 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 19:23 [PATCH v2 0/4] of: overlay: Assorted fixes Pantelis Antoniou
2015-04-07 19:23 ` Pantelis Antoniou
2015-04-07 19:23 ` [PATCH v2 2/4] of: overlay: kobjectify overlay objects Pantelis Antoniou
     [not found] ` <1428434632-13789-1-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-04-07 19:23   ` [PATCH v2 1/4] of: unittest: overlay: Keep track of created overlays Pantelis Antoniou
2015-04-07 19:23     ` Pantelis Antoniou
     [not found]     ` <1428434632-13789-2-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-04-15  1:29       ` Rob Herring
2015-04-15  1:29         ` Rob Herring
2015-04-07 19:23   ` [PATCH v2 3/4] of: overlay: Add sysfs attributes Pantelis Antoniou
2015-04-07 19:23     ` Pantelis Antoniou
     [not found]     ` <1428434632-13789-4-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-04-15  1:27       ` Rob Herring
2015-04-15  1:27         ` Rob Herring
     [not found]         ` <CAL_JsqLMVBfQpmSjg9qfOvtM3RXMY3Dm+knN8h54gDCzx513-g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-23 12:00           ` Pantelis Antoniou
2015-04-23 12:00             ` Pantelis Antoniou
     [not found]             ` <6E391B8F-936A-4FD1-B8CC-C9B5FCE0B291-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-04-23 12:33               ` Greg KH
2015-04-23 12:33                 ` Greg KH
2015-04-23 12:39                 ` Pantelis Antoniou
     [not found]                   ` <98237E9E-04CB-4CD5-8B2F-63F070B54459-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-04-23 12:54                     ` Greg KH
2015-04-23 12:54                       ` Greg KH
     [not found]                       ` <20150423125441.GA32303-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-04-23 12:59                         ` Pantelis Antoniou
2015-04-23 12:59                           ` Pantelis Antoniou
2015-04-23 13:04                           ` Greg KH [this message]
2015-04-07 19:23 ` [PATCH v2 4/4] Documentation: ABI: /sys/firmware/devicetree/overlays Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150423130409.GA4437@kroah.com \
    --to=greg@kroah.com \
    --cc=akpm@linux-foundation.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@secretlab.ca \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mporter@konsulko.com \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=robherring2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.