All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: lee.jones@linaro.org, linus.walleij@linaro.org, gnurou@gmail.com,
	myungjoo.ham@samsung.com, cw00.choi@samsung.com,
	ckeepax@opensource.wolfsonmicro.com,
	patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 7/8] ASoC: wm8998: Initial WM8998 codec driver
Date: Thu, 23 Apr 2015 18:54:55 +0100	[thread overview]
Message-ID: <20150423175455.GY22845@sirena.org.uk> (raw)
In-Reply-To: <20150423142823.GB17323@opensource.wolfsonmicro.com>

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

On Thu, Apr 23, 2015 at 03:28:23PM +0100, Richard Fitzgerald wrote:

> I'm not sure this is really a routing or widget problem. Problem is that
> if the muxed inputs are analogue we need to provide separate ALSA controls
> for the left and right mux because it is allowed to use them as two
> independant mono channels with separate muxing. But if they are
> configured as digital the mux controls are ganged so must be set the

I understand this, it's what prompted my comment.

> same. I don't feel good about registering a single mux control if its
> digital and two if its analogue because that means the codec's control
> list depends on a pdata option. I could implement the control pair

I don't see that as a problem, it's not like the disallowed options
would ever meaningfully exist for users on an affected system.  Why do
you see this as a problem?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-04-23 17:54 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 12:33 [PATCH 0/8] Add support for Wolfson WM8998 and WM1814 codecs Richard Fitzgerald
2015-04-21 12:33 ` [PATCH 1/8] mfd: arizona: Split INx_MODE into two fields Richard Fitzgerald
2015-04-21 12:33   ` Richard Fitzgerald
2015-04-21 12:33 ` [PATCH 2/8] ASoC: arizona: add defines for single-input gain control Richard Fitzgerald
2015-04-21 12:33   ` Richard Fitzgerald
2015-04-22 11:05   ` Mark Brown
2015-10-02 17:13   ` Applied "ASoC: arizona: add defines for single-input gain control" to the asoc tree Mark Brown
2015-04-21 12:33 ` [PATCH 3/8] mfd: arizona: Add support for WM8998 and WM1814 Richard Fitzgerald
     [not found]   ` <1429619636-25478-4-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-04-22 11:08     ` Mark Brown
2015-04-22 11:08       ` Mark Brown
2015-04-27 12:40       ` Richard Fitzgerald
2015-04-21 12:33 ` [PATCH 4/8] gpio: arizona: add " Richard Fitzgerald
2015-04-28 12:59   ` Linus Walleij
2015-04-21 12:33 ` [PATCH 5/8] regulator: " Richard Fitzgerald
2015-04-21 12:33   ` Richard Fitzgerald
2015-04-22 11:04   ` Mark Brown
2015-04-21 12:33 ` [PATCH 6/8] extcon: arizona: Add " Richard Fitzgerald
2015-04-22  5:53   ` Chanwoo Choi
2015-04-22  9:19     ` Richard Fitzgerald
2015-04-22 10:20       ` Chanwoo Choi
2015-04-23 14:15         ` Richard Fitzgerald
2015-04-23 14:15           ` [alsa-devel] " Richard Fitzgerald
2015-04-24  0:59           ` Chanwoo Choi
2015-04-21 12:33 ` [PATCH 7/8] ASoC: wm8998: Initial WM8998 codec driver Richard Fitzgerald
2015-04-22 11:00   ` Mark Brown
     [not found]     ` <20150422110030.GQ22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-23 14:28       ` Richard Fitzgerald
2015-04-23 14:28         ` Richard Fitzgerald
2015-04-23 17:54         ` Mark Brown [this message]
2015-04-22 19:46   ` Paul Bolle
2015-04-21 12:33 ` [PATCH 8/8] Documentation: Add WM8998/WM1814 device tree bindings Richard Fitzgerald
2015-04-23  2:05   ` Austin, Brian
2015-04-23  2:05     ` [alsa-devel] " Austin, Brian
2015-04-23 14:46     ` Richard Fitzgerald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150423175455.GY22845@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=ckeepax@opensource.wolfsonmicro.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gnurou@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=rf@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.