From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlYLi-0002Lb-Ub for qemu-devel@nongnu.org; Fri, 24 Apr 2015 03:48:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlYLf-0001RV-GM for qemu-devel@nongnu.org; Fri, 24 Apr 2015 03:48:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlYLf-0001RG-5T for qemu-devel@nongnu.org; Fri, 24 Apr 2015 03:48:31 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3O7mTfL002011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 24 Apr 2015 03:48:30 -0400 Date: Fri, 24 Apr 2015 09:48:26 +0200 From: Kashyap Chamarthy Message-ID: <20150424074826.GG10067@tesla.redhat.com> References: <1429793161-25677-1-git-send-email-kchamart@redhat.com> <55397B40.3070602@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55397B40.3070602@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, jsnow@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com On Thu, Apr 23, 2015 at 05:07:44PM -0600, Eric Blake wrote: > On 04/23/2015 06:46 AM, Kashyap Chamarthy wrote: > > Although the canonical source of reference for QMP commands is > > qapi-schema.json, for consistency's sake, update qmp-commands.hx to > > state the list of supported transactionable operations, namely: > > > > drive-backup > > blockdev-backup > > blockdev-snapshot-internal-sync > > abort > > block-dirty-bitmap-add > > block-dirty-bitmap-clear > > > > NB: The 'block-dirty-bitmap-add' and 'block-dirty-bitmap-add' commands Another thing I didn't notice: I enntered the same command name twice. > > will be available once the in-review "transactionless incremental > > backup" patch series[1] is merged upstream. > > > > [1] http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg02161.html > > > > Signed-off-by: Kashyap Chamarthy > > --- > > qmp-commands.hx | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > > > -Atomically operate on one or more block devices. The only supported operations > > -for now are drive-backup, internal and external snapshotting. A list of > > -dictionaries is accepted, that contains the actions to be performed. > > -If there is any failure performing any of the operations, all operations > > -for the group are abandoned. > > +Atomically operate on one or more block devices. Operations that are > > +currently supported: drive-backup, blockdev-backup, > > +blockdev-snapshot-sync, blockdev-snapshot-internal-sync, abort, > > +block-dirty-bitmap-add, block-dirty-bitmap-clear (refer > > s/refer/refer to the/ > > +qemu/qapi-schema.json file for minimum required QEMU versions for these > > +commands). A list of dictionaries is accepted, that contains the actions > > +to be performed. If there is any failure performing any of the > > +operations, all operations for the group are abandoned. > > > > With that change, > Reviewed-by: Eric Blake Thanks. I'll send a v2 fixing what you found and the other mistake (double entry of the same command) in the commit message. -- /kashyap