From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: libxl, flexarray_append_pair usage Date: Fri, 24 Apr 2015 11:16:00 +0200 Message-ID: <20150424091600.GA11059@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Wei Liu , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Fri, Apr 24, Olaf Hering wrote: > flexarray_append(back, "state"); > - flexarray_append(back, GCSPRINTF("%d", 1)); > + flexarray_append(back, GCSPRINTF("%d", XenbusStateInitialising)); Should all such code be converted to flexarray_append_pair? To reduce line length a short macro should be added, like FLXAP or FLXPAIR or something else. Olaf