From: "Frank Ch. Eigler" <fche@redhat.com>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
"Josh Stone" <jistone@redhat.com>,
"Jakub Jelinek" <jakub@redhat.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Markus Trippelsdorf" <markus@trippelsdorf.de>,
"Michel Dänzer" <michel@daenzer.net>
Subject: Re: [PATCH] Kbuild: Add an option to enable GCC VTA
Date: Fri, 24 Apr 2015 09:42:37 -0400 [thread overview]
Message-ID: <20150424134237.GA9185@redhat.com> (raw)
In-Reply-To: <CA+5PVA509z3_j7c3hZYSj0BzHH9UntrXPFAfiikCCf_eRyyTig@mail.gmail.com>
Hi, Josh -
On Fri, Apr 24, 2015 at 08:40:02AM -0400, Josh Boyer wrote:
> [...]
> Frank, did you rebase this against some newer tree or something?
Yes; the lib/Kconfig.debug part didn't apply to current git.
> Curious why you sent it again.
At least as a patch-ping; the poor-debuginfo problems are reported to
affect non-fedora users too.
> > +ifdef CONFIG_DEBUG_INFO_VTA
> > +KBUILD_CFLAGS += $(call cc-option, -fvar-tracking-assignments)
> > +else
> > +KBUILD_CFLAGS += $(call cc-option, -fno-var-tracking-assignments)
> > +endif
> > +
>
> Is there a reason you moved this hunk under the DWARF4 options instead
> of modifying it in-place like the original patch did?
Yes, this version appears a little safer, in the sense that without
CONFIG_DEBUG_INFO, neither setting of CONFIG_DEBUG_INFO_VTA would
affect the CFLAGS. (In fact, Jakub advises the positive polarity
-fvar-tracking-assignments is redundant with -g, and the negative
polarity one only provides codegen-bug-protection in the
CONFIG_DEBUG_INFO case.)
- FChE
next prev parent reply other threads:[~2015-04-24 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 18:40 [PATCH RESEND] Kbuild: Add an option to enable GCC VTA Josh Stone
2014-11-24 21:46 ` Michal Marek
2014-11-24 23:46 ` Josh Stone
2014-11-25 21:05 ` Michal Marek
2014-11-25 21:24 ` Josh Boyer
2015-04-23 21:25 ` [PATCH] " Frank Ch. Eigler
2015-04-24 12:40 ` Josh Boyer
2015-04-24 13:42 ` Frank Ch. Eigler [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-08-05 23:59 [PATCH 3.15 33/37] Fix gcc-4.9.0 miscompilation of load_balance() in scheduler Linus Torvalds
2014-10-06 21:05 ` [PATCH] Kbuild: Add an option to enable GCC VTA Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424134237.GA9185@redhat.com \
--to=fche@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jakub@redhat.com \
--cc=jistone@redhat.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=michel@daenzer.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.