From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] gpio: omap: Allow building as a loadable module Date: Fri, 24 Apr 2015 09:22:47 -0700 Message-ID: <20150424162247.GT18048@atomide.com> References: <1429833382-28532-1-git-send-email-tony@atomide.com> <20150424161127.GG5692@saruman.tx.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20150424161127.GG5692@saruman.tx.rr.com> Sender: linux-omap-owner@vger.kernel.org To: Felipe Balbi Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Javier Martinez Canillas , Grygorii Strashko , Kevin Hilman , Nishanth Menon , Santosh Shilimkar List-Id: linux-gpio@vger.kernel.org * Felipe Balbi [150424 09:14]: > On Thu, Apr 23, 2015 at 04:56:22PM -0700, Tony Lindgren wrote: > > We currently get all kinds of errors building the omap gpio driver > > as a module starting with: > > > > undefined reference to `omap2_gpio_resume_after_idle' > > undefined reference to `omap2_gpio_prepare_for_idle' > > ... > > > > Let's fix the issue by adding inline functions to the header. > > Note that we can now also remove the two unused functions for > > omap_set_gpio_debounce and omap_set_gpio_debounce_time. > > > > Then doing rmmod on the module produces further warnings > > because of missing exit related functions. Let's add those. > > > > And finally, we can make the Kconfig entry just a tristate > > option that's selected for omaps. > > > > Cc: Felipe Balbi > > Cc: Javier Martinez Canillas > > Cc: Grygorii Strashko > > Cc: Kevin Hilman > > Cc: Nishanth Menon > > Cc: Santosh Shilimkar > > Signed-off-by: Tony Lindgren > > Just to be clear: when GPIO is a module, we can't really idle, can we ? Right we cannot do off idle because of the context loss until we have some way to register driver specific idle functions. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 24 Apr 2015 09:22:47 -0700 Subject: [PATCH] gpio: omap: Allow building as a loadable module In-Reply-To: <20150424161127.GG5692@saruman.tx.rr.com> References: <1429833382-28532-1-git-send-email-tony@atomide.com> <20150424161127.GG5692@saruman.tx.rr.com> Message-ID: <20150424162247.GT18048@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Felipe Balbi [150424 09:14]: > On Thu, Apr 23, 2015 at 04:56:22PM -0700, Tony Lindgren wrote: > > We currently get all kinds of errors building the omap gpio driver > > as a module starting with: > > > > undefined reference to `omap2_gpio_resume_after_idle' > > undefined reference to `omap2_gpio_prepare_for_idle' > > ... > > > > Let's fix the issue by adding inline functions to the header. > > Note that we can now also remove the two unused functions for > > omap_set_gpio_debounce and omap_set_gpio_debounce_time. > > > > Then doing rmmod on the module produces further warnings > > because of missing exit related functions. Let's add those. > > > > And finally, we can make the Kconfig entry just a tristate > > option that's selected for omaps. > > > > Cc: Felipe Balbi > > Cc: Javier Martinez Canillas > > Cc: Grygorii Strashko > > Cc: Kevin Hilman > > Cc: Nishanth Menon > > Cc: Santosh Shilimkar > > Signed-off-by: Tony Lindgren > > Just to be clear: when GPIO is a module, we can't really idle, can we ? Right we cannot do off idle because of the context loss until we have some way to register driver specific idle functions. Regards, Tony