All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Padovan <gustavo@padovan.org>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: linux-samsung-soc@vger.kernel.org,
	gustavo.padovan@collabora.co.uk, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/exynos: mixer: cleanup pixelformat handling
Date: Fri, 24 Apr 2015 15:14:40 -0300	[thread overview]
Message-ID: <20150424181440.GF13025@joana> (raw)
In-Reply-To: <aae08db4a8603a5109e5e3946e30e770@math.uni-bielefeld.de>

Hi Tobias,

2015-04-24 Tobias Jakobi <tjakobi@math.uni-bielefeld.de>:

> On 2015-04-24 03:48, Joonyoung Shim wrote:
> >Hi Tobias,
> >
> >On 04/23/2015 09:12 PM, Tobias Jakobi wrote:
> >>Move the defines for the pixelformats that the mixer supports out
> >>of mixer_graph_buffer() to the top of the source.
> >>Then select the mixer pixelformat (pf) in mixer_graph_buffer() based on
> >>the plane's pf (and not bpp).
> >>Also add handling of RGB565 and XRGB1555 to the switch statement and
> >>exit early if the plane has an unsupported pf.
> >>
> >>Partially based on 'drm/exynos: enable/disable blend based on pixel
> >>format' by Gustavo Padovan <gustavo.padovan@collabora.co.uk>.
> >>
> >>Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> >>---
> >> drivers/gpu/drm/exynos/exynos_mixer.c | 32
> >>++++++++++++++++++++++----------
> >> 1 file changed, 22 insertions(+), 10 deletions(-)
> >>
> >>diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c
> >>b/drivers/gpu/drm/exynos/exynos_mixer.c
> >>index fbec750..1bd23ee 100644
> >>--- a/drivers/gpu/drm/exynos/exynos_mixer.c
> >>+++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> >>@@ -44,6 +44,12 @@
> >> #define MIXER_WIN_NR		3
> >> #define MIXER_DEFAULT_WIN	0
> >>
> >>+/* The pixelformats that are natively supported by the mixer. */
> >>+#define MIXER_PIXELFORMAT_RGB565 4
> >>+#define MIXER_PIXELFORMAT_ARGB1555 5
> >>+#define MIXER_PIXELFORMAT_ARGB4444 6
> >>+#define MIXER_PIXELFORMAT_ARGB8888 7
> >>+
> >
> >Seems be long, how about s/PIXELFORMAT/FORMAT or just MIXER_RGB565 ... ?
> >Please use tab between define name and value.
> How about MXR_FORMAT_XYZ, to stay consistent with the regs-mixer header?

I'm fine with MXR_FORMAT_XYZ. Other than that:

Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>

	Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-04-24 18:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 12:12 drm/exynos: two small fixes (v2) Tobias Jakobi
2015-04-23 12:12 ` [PATCH 1/2] drm/exynos: mixer: cleanup pixelformat handling Tobias Jakobi
2015-04-24  1:48   ` Joonyoung Shim
2015-04-24  8:10     ` Tobias Jakobi
2015-04-24 18:14       ` Gustavo Padovan [this message]
2015-04-25 18:08         ` Tobias Jakobi
2015-04-27  6:33       ` Joonyoung Shim
2015-04-27 12:06         ` Tobias Jakobi
2015-04-23 12:12 ` [PATCH 2/2] drm/exynos: cleanup exynos_drm_plane Tobias Jakobi
2015-04-24  1:54   ` Joonyoung Shim
2015-04-24 18:13     ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150424181440.GF13025@joana \
    --to=gustavo@padovan.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.