From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:38291 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbbDZHUE (ORCPT ); Sun, 26 Apr 2015 03:20:04 -0400 Date: Sun, 26 Apr 2015 09:19:58 +0200 From: Greg KH To: Dirk Behme Cc: stable@vger.kernel.org Subject: Re: [PATCH for 3.19.y to 3.10.y] net: sysctl_net_core: remove unused variable one Message-ID: <20150426071958.GA31992@kroah.com> References: <1430032263-5094-1-git-send-email-dirk.behme@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1430032263-5094-1-git-send-email-dirk.behme@gmail.com> Sender: stable-owner@vger.kernel.org List-ID: On Sun, Apr 26, 2015 at 09:11:03AM +0200, Dirk Behme wrote: > Back porting the upstream commit b1cb59cf2efe7 ("net: sysctl_net_core: check > SNDBUF and RCVBUF for min length") to -stable introduces a compiler warning > > net/core/sysctl_net_core.c:26:12: warning: ‘one’ defined but not used [-Wunused-variable] > static int one = 1; > > While upstream has an additional user of the variable 'one' after that commit > ("tstamp_allow_data"), -stable doesn't have any user of 'one' any more, resulting > in above compiler warning. Or in other words: -stable doesn't have the > commit b245be1f4db1a0 ("net-timestamp: no-payload only sysctl") introducing the > additional user of 'one'. > > Fix the compiler warning by removing the unused variable. No, this was done on purpose, sorry, I can't take this patch. The network maintainer wants it this way to be easier to backport things. We can live with the compiler warning. thanks, greg k-h