All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: liam.r.girdwood@linux.intel.com, tiwai@suse.de,
	alsa-devel@alsa-project.org, Jeeja KP <jeeja.kp@intel.com>,
	patches.audio@intel.com
Subject: Re: [RFC 1/7] ASoC: hda: Add skl dsp init and registering with SST IPC lib
Date: Sun, 26 Apr 2015 19:23:25 +0530	[thread overview]
Message-ID: <20150426135325.GP2738@intel.com> (raw)
In-Reply-To: <20150424173657.GA22845@sirena.org.uk>


[-- Attachment #1.1: Type: text/plain, Size: 1426 bytes --]

On Fri, Apr 24, 2015 at 06:36:57PM +0100, Mark Brown wrote:
> On Sun, Apr 19, 2015 at 02:27:27AM +0530, Vinod Koul wrote:
> 
> >  config SND_SOC_I2S_SKL_MACH
> >          tristate "SOC Machine Audio driver for SKL Onboard I2S"
> > +	 select SND_HDA_DSP_LOADER
> 
> Looking at what this is modifying it really looks like there's some
> other patch series I wanted to look at first?
Yes that was the SKL PCM driver series. I will repost that in this week
along with few more changes, so you can look at updated series.


> 
> > diff --git a/sound/soc/hda/hda_skl.h b/sound/soc/hda/hda_skl.h
> > index 0cc2ac69a9ab..914ea05da6aa 100644
> > --- a/sound/soc/hda/hda_skl.h
> > +++ b/sound/soc/hda/hda_skl.h
> > @@ -1,15 +1,3 @@
> > -/*
> > - *  This program is free software; you can redistribute it and/or modify it
> > - *  under the terms of the GNU General Public License as published by the Free
> > - *  Software Foundation; either version 2 of the License, or (at your option)
> > - *  any later version.
> > - *
> > - *  This program is distributed in the hope that it will be useful, but WITHOUT
> > - *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> > - *  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> > - *  more details.
> > - */
> > -
> 
> Oh?  
Terrible :(

Will try to see these dont creep in patches

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2015-04-26 13:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18 20:57 [RFC 0/7] ASoC: hda - ASoC DSP widget event handlers Vinod Koul
2015-04-18 20:57 ` [RFC 1/7] ASoC: hda: Add skl dsp init and registering with SST IPC lib Vinod Koul
2015-04-24 17:36   ` Mark Brown
2015-04-26 13:53     ` Vinod Koul [this message]
2015-04-18 20:57 ` [RFC 2/7] ASoC: hda: add helper to configure module params Vinod Koul
2015-04-24 17:38   ` Mark Brown
2015-04-26 14:06     ` Vinod Koul
2015-04-18 20:57 ` [RFC 3/7] ASoC: hda: add FW module init/bind IPC Vinod Koul
2015-04-18 20:57 ` [RFC 4/7] ASoC: hda: add FW pipe create/delete/set_pipe_state IPC Vinod Koul
2015-04-18 20:57 ` [RFC 5/7] ASOC: hda: add DSP platfrom controls widget event handlers Vinod Koul
2015-04-24 17:51   ` Mark Brown
2015-04-26 14:14     ` Vinod Koul
2015-04-18 20:57 ` [RFC 6/7] ASoC: hda: Add support for SSP register settings Vinod Koul
2015-04-24 17:55   ` Mark Brown
2015-04-26 14:18     ` Vinod Koul
2015-04-27 14:15       ` Mark Brown
2015-04-29 23:45         ` Pierre-Louis Bossart
2015-04-29 23:50           ` Pierre-Louis Bossart
2015-04-30  4:39             ` Vinod Koul
2015-04-30 14:36               ` Mark Brown
2015-04-30 15:55                 ` Pierre-Louis Bossart
2015-04-18 20:57 ` [RFC 7/7] ASoC: hda: Apply dai params_fixup for DSP widgets Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150426135325.GP2738@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jeeja.kp@intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.