From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv4 02/18] pkg-generic: take into account patch dependencies in source, external-deps and legal-info
Date: Sun, 26 Apr 2015 17:15:54 +0200 [thread overview]
Message-ID: <20150426151554.GD4809@free.fr> (raw)
In-Reply-To: <1430041876-16436-3-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
On 2015-04-26 11:51 +0200, Thomas Petazzoni spake thusly:
> The $(1)-all-{source,external-deps,legal-info} targets currently only
> take care of the dependencies in <pkg>_DEPENDENCIES, but not
> <pkg>_PATCH_DEPENDENCIES. This patch fixes that by introducing a
> <pkg>_FINAL_ALL_DEPENDENCIES. It also reworks the $(1)-show-depends
> target to make use of <pkg>_FINALL_ALL_DEPENDENCIES.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[tested a "make source" and "make external-deps" and "make legal-info"
on a randpackageconfig]
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/pkg-generic.mk | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 455bdf1..dd8c4c9 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -431,6 +431,7 @@ endif
> # Eliminate duplicates in dependencies
> $(2)_FINAL_DEPENDENCIES = $$(sort $$($(2)_DEPENDENCIES))
> $(2)_FINAL_PATCH_DEPENDENCIES = $$(sort $$($(2)_PATCH_DEPENDENCIES))
> +$(2)_FINAL_ALL_DEPENDENCIES = $$(sort $$($(2)_FINAL_DEPENDENCIES) $$($(2)_FINAL_PATCH_DEPENDENCIES))
>
> $(2)_INSTALL_STAGING ?= NO
> $(2)_INSTALL_IMAGES ?= NO
> @@ -583,7 +584,7 @@ $(1)-show-version:
> @echo $$($(2)_VERSION)
>
> $(1)-show-depends:
> - @echo $$(sort $$($(2)_FINAL_DEPENDENCIES) $$($(2)_FINAL_PATCH_DEPENDENCIES))
> + @echo $$($(2)_FINAL_ALL_DEPENDENCIES)
>
> $(1)-graph-depends: graph-depends-requirements
> @$$(INSTALL) -d $$(GRAPHS_DIR)
> @@ -592,11 +593,14 @@ $(1)-graph-depends: graph-depends-requirements
> |tee $$(GRAPHS_DIR)/$$(@).dot \
> |dot $$(BR2_GRAPH_DOT_OPTS) -T$$(BR_GRAPH_OUT) -o $$(GRAPHS_DIR)/$$(@).$$(BR_GRAPH_OUT)
>
> -$(1)-all-source: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-source) $(1)-source
> +$(1)-all-source: $(1)-source
> +$(1)-all-source: $$(foreach p,$$($(2)_FINAL_ALL_DEPENDENCIES),$$(p)-all-source)
>
> -$(1)-all-external-deps: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-external-deps) $(1)-external-deps
> +$(1)-all-external-deps: $(1)-external-deps
> +$(1)-all-external-deps: $$(foreach p,$$($(2)_FINAL_ALL_DEPENDENCIES),$$(p)-all-external-deps)
>
> -$(1)-all-legal-info: $$(foreach p,$$($(2)_FINAL_DEPENDENCIES),$$(p)-all-legal-info) $(1)-legal-info
> +$(1)-all-legal-info: $(1)-legal-info
> +$(1)-all-legal-info: $$(foreach p,$$($(2)_FINAL_ALL_DEPENDENCIES),$$(p)-all-legal-info)
>
> $(1)-dirclean: $$($(2)_TARGET_DIRCLEAN)
>
> --
> 2.1.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-04-26 15:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 9:50 [Buildroot] [PATCHv4 00/18] Package based 'source', 'legal-info', 'source-check' and 'external-deps' Thomas Petazzoni
2015-04-26 9:50 ` [Buildroot] [PATCHv4 01/18] fs: only add non rootfs- targets to PACKAGES Thomas Petazzoni
2015-04-26 10:16 ` Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 02/18] pkg-generic: take into account patch dependencies in source, external-deps and legal-info Thomas Petazzoni
2015-04-26 15:15 ` Yann E. MORIN [this message]
2015-04-26 9:51 ` [Buildroot] [PATCHv4 03/18] Makefile: use the package infra based external-deps Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 04/18] pkg-download: remove support for the SHOW_EXTERNAL_DEPS DL_MODE Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 05/18] Makefile: move source-check outside of noconfig_targets Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 06/18] pkg-download: extend DOWNLOAD_INNER, add a SOURCE_CHECK macro Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 07/18] pkg-generic: implement source-check targets Thomas Petazzoni
2015-04-26 15:20 ` Yann E. MORIN
2015-04-26 20:22 ` Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 08/18] Makefile: implement a package based source-check target Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 09/18] pkg-generic: remove the .stamp_rsync_sourced fake stamp file Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 10/18] pkg-generic: don't use DL_MODE in .stamp_downloaded Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 11/18] pkg-download: get rid of DL_MODE Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 12/18] pkg-download: fix indentation for SOURCE_CHECK_* macros Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 13/18] pkg-generic: introduce a <pkg>_ALL_DOWNLOADS variable and factorize code Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 14/18] Makefile: implement the 'source' target using the package infrastructure Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 15/18] Makefile: remove unneeded variables Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 16/18] Makefile: add BR_BUILDING variable Thomas Petazzoni
2015-04-26 9:51 ` [Buildroot] [PATCHv4 17/18] packages: refactor checks using BR_BUILDING Thomas Petazzoni
2015-04-26 15:31 ` Yann E. MORIN
2015-04-26 9:51 ` [Buildroot] [PATCHv4 18/18] Makefile: add a few more targets to nobuild_targets Thomas Petazzoni
2015-04-26 15:40 ` Yann E. MORIN
2015-04-26 20:23 ` Thomas Petazzoni
2015-04-26 20:23 ` [Buildroot] [PATCHv4 00/18] Package based 'source', 'legal-info', 'source-check' and 'external-deps' Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150426151554.GD4809@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.