From: Johan Hovold <johan@kernel.org>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Johan Hovold <johan@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Mark Enstone <Mark.Enstone@silabs.com>,
stable@vger.kernel.org
Subject: Re: Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback()
Date: Mon, 27 Apr 2015 11:44:58 +0200 [thread overview]
Message-ID: <20150427094458.GH27877@localhost> (raw)
In-Reply-To: <SN1PR0701MB1918FEB1B2765B17EBC98CFDE0FC0@SN1PR0701MB1918.namprd07.prod.outlook.com>
Hi Sasha,
On Wed, Apr 08, 2015 at 05:29:16PM +0000, Mark Enstone wrote:
> Everyone, thank you for your attention and suggestions.
>
> Johan, perfect, thank you, that did indeed help and has fixed the
> issue I was seeing.
>
> The change replaced dev_err() with dev_dbg() -- thus not logging (by
> default) what was a very noisy flood of messages. Does that simply
> change timing enough such that the USB HCD has time to process the
> disconnect? Or is there something else going on that I'm missing?
> > -----Original Message-----
> > From: Johan Hovold [mailto:jhovold@gmail.com] On Behalf Of Johan Hovold
> > Sent: Tuesday, April 07, 2015 2:58 PM
> > To: Mark Enstone
> > Cc: linux-usb@vger.kernel.org
> > Subject: Re: Question: drivers/usb/serial/generic.c:
> > usb_serial_generic_read_bulk_callback()
> > Could you try updating to 3.19 (or later) or to cherry pick aa8e22128b40
> > ("usb: serial: silence all non-critical read errors") and see if that helps?
> >
> > We should backport that one to stable either way.
You may want to add aa8e22128b40 ("usb: serial: silence all non-critical
read errors") to 3.18-stable as it fixes a lock-up-on-disconnect
regression with at least two controllers (3.15 through 3.18 are
affected).
Thanks,
Johan
next parent reply other threads:[~2015-04-27 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BY1PR0701MB19105B60D7D783BE1323DB1EE0FD0@BY1PR0701MB1910.namprd07.prod.outlook.com>
[not found] ` <20150407195741.GA12027@localhost>
[not found] ` <SN1PR0701MB1918FEB1B2765B17EBC98CFDE0FC0@SN1PR0701MB1918.namprd07.prod.outlook.com>
2015-04-27 9:44 ` Johan Hovold [this message]
2015-04-27 14:32 ` Question: drivers/usb/serial/generic.c: usb_serial_generic_read_bulk_callback() Sasha Levin
2015-05-04 9:14 ` Luis Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427094458.GH27877@localhost \
--to=johan@kernel.org \
--cc=Mark.Enstone@silabs.com \
--cc=linux-usb@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.