From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bh-25.webhostbox.net ([208.91.199.152]:35989 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbbD0PgX (ORCPT ); Mon, 27 Apr 2015 11:36:23 -0400 Received: from mailnull by bh-25.webhostbox.net with sa-checked (Exim 4.85) (envelope-from ) id 1Yml52-003ktq-3d for stable@vger.kernel.org; Mon, 27 Apr 2015 15:36:20 +0000 Date: Mon, 27 Apr 2015 08:36:16 -0700 From: Guenter Roeck To: Sasha Levin Cc: stable Subject: Re: v3.18-stable-queue build failures Message-ID: <20150427153616.GA5701@roeck-us.net> References: <553CBE54.7060303@roeck-us.net> <553DAA5A.6060000@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <553DAA5A.6060000@oracle.com> Sender: stable-owner@vger.kernel.org List-ID: On Sun, Apr 26, 2015 at 11:17:46PM -0400, Sasha Levin wrote: > On 04/26/2015 06:30 AM, Guenter Roeck wrote: > > Hi, > > > > almost all builds in v3.18-stable-queue fail with > > > > In file included from net/socket.c:74:0: > > include/linux/if_vlan.h: In function 'vlan_put_tag': > > include/linux/if_vlan.h:409:3: error: implicit declaration of function '__vlan_put_tag' [-Werror=implicit-function-declaration] > > include/linux/if_vlan.h:409:3: warning: return makes pointer from integer without a cast [enabled by default] > > > > groeck@server:~/src/linux-stable$ git grep __vlan_put_tag > > include/linux/if_vlan.h: return __vlan_put_tag(skb, vlan_proto, vlan_tci); > > > > It appears that 'vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto' was incomplete > > for v3.18. > > Thanks! > > This was actually missing b4bef1b575 ("vlan: kill vlan_put_tag helper"). > > Fixed and re-pushed. > Hi Sasha, much better now but there are still several build failures. drivers/net/ethernet/broadcom/bnx2x/bnx2x.h: In function 'bnx2x_fp_busy_poll_init': drivers/net/ethernet/broadcom/bnx2x/bnx2x.h:625:2: error: implicit declaration of function 'WRITE_ONCE' --- drivers/net/vxlan.c: In function 'vxlan_xmit_skb': drivers/net/vxlan.c:1646:2: error: too few arguments to function 'iptunnel_handle_offloads' include/net/ip_tunnels.h:181:17: note: declared here Guenter