From: "Emilio G. Cota" <cota@braap.org>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition
Date: Mon, 27 Apr 2015 11:39:46 -0400 [thread overview]
Message-ID: <20150427153946.GA25629@flamenco> (raw)
In-Reply-To: <CAEgOgz6eW5uULkBaw_Stco4uTwVAvrBKKOH3Utebc4v6Vp+TfQ@mail.gmail.com>
On Sun, Apr 26, 2015 at 19:18:41 -0700, Peter Crosthwaite wrote:
> On Sun, Apr 26, 2015 at 3:04 PM, Emilio G. Cota <cota@braap.org> wrote:
> > It's defined in osdep.h and shouldn't be redefined here.
> >
> > Signed-off-by: Emilio G. Cota <cota@braap.org>
>
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Thanks for having a look!
> It looks like there may be another one too:
>
> hw/audio/fmopl.c:#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
That one is protected by #ifndef ARRAY_SIZE and AFAICT the file does not
include any qemu headers, so we can safely leave it as is.
Emilio
next prev parent reply other threads:[~2015-04-27 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 22:04 [Qemu-devel] [PATCH] i440fx-test: remove ARRAY_SIZE redefinition Emilio G. Cota
2015-04-27 2:18 ` Peter Crosthwaite
2015-04-27 15:39 ` Emilio G. Cota [this message]
2015-04-27 15:40 ` [Qemu-trivial] " Paolo Bonzini
2015-04-27 15:40 ` [Qemu-devel] " Paolo Bonzini
2015-04-29 6:31 ` [Qemu-trivial] " Michael Tokarev
2015-04-29 6:31 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150427153946.GA25629@flamenco \
--to=cota@braap.org \
--cc=lersek@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.